Page MenuHomePhabricator

Implement "auth.logout" Conduit API method
ClosedPublic

Authored by epriestley on Apr 3 2016, 4:13 PM.

Details

Summary

Ref T7303. Ref T7673. This implements an "auth.logout" which:

  • terminates all web sessions;
  • terminates the current OAuth token if called via OAuth; and
  • may always be called via OAuth.

(Since it consumes an OAuth token, even a "malicious" OAuth application can't really be that much of a jerk with this: it can't continuously log you out, since calling the method once kills the token. The application would need to ask your permission again to get a fresh token.)

The primary goal here is to let Phacility instances call this against the Phacility upstream, so that when you log out of an instance it also logs you out of your Phacility account (possibly with a checkbox or something).

This also smooths over the session token code. Before this change, your sessions would get logged out but when you reloaded we'd tell you your session was invalid.

Instead, try to clear the invalid session before telling the user there's an issue. I think that ssentially 100% of invalid sessions are a result of something in this vein (e.g., forced logout via Settings) nowadays, since the session code is generally stable and sane and has been for a long time.

Test Plan
  • Called auth.logout via console, got a reasonable logout experience.
  • Called auth.logout via OAuth.
    • Tried to make another call, verified OAuth token had been invalidated.
    • Verified web session had been invalidated.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 37587.Apr 3 2016, 4:13 PM
epriestley retitled this revision from to Implement "auth.logout" Conduit API method.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Apr 3 2016, 5:32 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 3 2016, 5:32 PM
This revision was automatically updated to reflect the committed changes.