Page MenuHomePhabricator
Differential D15593

Begin cleaning up OAuth scope handling
ClosedPublic
Actions

Authored by epriestley on Apr 3 2016, 3:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 12:37 AM
Unknown Object (File)
Thu, Dec 12, 6:39 AM
Unknown Object (File)
Fri, Dec 6, 11:48 PM
Unknown Object (File)
Tue, Dec 3, 8:14 AM
Unknown Object (File)
Sat, Nov 30, 2:24 PM
Unknown Object (File)
Sat, Nov 30, 2:24 PM
Unknown Object (File)
Sat, Nov 30, 2:23 PM
Unknown Object (File)
Sat, Nov 30, 2:14 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7303: Provide OAuth access to Conduit
Commits
rP60133b6fa5d5: Begin cleaning up OAuth scope handling
Summary

Ref T7303. OAuth scope handling never got fully modernized and is a bit of a mess.

Also introduce implicit "ALWAYS" and "NEVER" scopes.

Always give tokens access to meta-methods like conduit.getcapabilities and conduit.query. These do not expose user information.

Test Plan
  • Used a token to call user.whoami.
  • Used a token to call conduit.query.
  • Used a token to try to call user.query, got rebuffed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37586.Apr 3 2016, 3:41 PM
epriestley retitled this revision from to Begin cleaning up OAuth scope handling.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7303: Provide OAuth access to Conduit.
chad accepted this revision.Apr 3 2016, 4:50 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 3 2016, 4:50 PM
Closed by commit rP60133b6fa5d5: Begin cleaning up OAuth scope handling (authored by epriestley, committed by epriestley). · Explain WhyApr 4 2016, 4:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37613

View Options

src/applications/conduit/call/ConduitCall.php

Loading...
View Options

src/applications/conduit/controller/PhabricatorConduitAPIController.php

Loading...
View Options

src/applications/conduit/controller/PhabricatorConduitConsoleController.php

Loading...
View Options

src/applications/conduit/method/ConduitAPIMethod.php

Loading...
View Options

src/applications/conduit/method/ConduitGetCapabilitiesConduitAPIMethod.php

Loading...
View Options

src/applications/conduit/method/ConduitQueryConduitAPIMethod.php

Loading...
View Options

src/applications/oauthserver/PhabricatorOAuthServer.php

Loading...
View Options

src/applications/oauthserver/PhabricatorOAuthServerScope.php

Loading...
View Options

src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php

Loading...
View Options

src/applications/oauthserver/query/PhabricatorOAuthClientAuthorizationQuery.php

Loading...
View Options

src/applications/oauthserver/storage/PhabricatorOAuthServerAccessToken.php

Loading...
Phabricator · Built by Phacility