Page MenuHomePhabricator

Extract GitHub actor IDs from GitHub events
ClosedPublic

Authored by epriestley on Mar 28 2016, 6:44 PM.

Details

Summary

Ref T10538. This probably gets push events where GitHub does not recognize the author wrong, but I don't have any of those yet.

Test Plan

Added and ran unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Extract GitHub actor IDs from GitHub events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

Uh, not sure it's actually possible to query GitHub for users by user ID, so this may be 100% useless. Let me figure that out first.

It looks like:

  • No APIs exist for querying user by ID (/users and /search/users do not appear to have any mechanisms for this). You can only query by username.
  • Users can change their names at any time.
  • Users can change their names to the name of a previously existing user (sometimes??).
  • hurf durf durf derp derp derp derp

HUE HUE HUE HUE

https://api.github.com/users?since=102630&per_page=1

So this is perfect as-is. Glorious!

chad edited edge metadata.
This revision is now accepted and ready to land.Mar 28 2016, 7:22 PM
This revision was automatically updated to reflect the committed changes.