Page MenuHomePhabricator
Differential D15523

Update Harbormaster for two column
ClosedPublic
Actions

Authored by chad on Mar 25 2016, 9:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 16, 6:34 AM
Unknown Object (File)
Sun, Feb 9, 1:05 AM
Unknown Object (File)
Sun, Feb 9, 1:05 AM
Unknown Object (File)
Sun, Feb 9, 1:05 AM
Unknown Object (File)
Sun, Feb 9, 1:05 AM
Unknown Object (File)
Wed, Feb 5, 3:19 PM
Unknown Object (File)
Mon, Feb 3, 9:29 PM
Unknown Object (File)
Mon, Feb 3, 5:25 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPd76652b33178: Update Harbormaster for two column
Summary

Updates the Harbormaster UI to match the new two column everywhere else.

Test Plan

Did best I could, tested builds, plans, steps, buildables. Unable to test lint/unit locally, I need to set that up. Kick the tires for me pls. :3

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 37421.Mar 25 2016, 9:07 PM
chad retitled this revision from to Update Harbormaster for two column.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 25 2016, 9:07 PM
epriestley accepted this revision.Mar 25 2016, 9:10 PM
epriestley edited edge metadata.

Unit test detail view has smooshed "Bxxx" and title, and also is two-column but with no curtain:

Screen Shot 2016-03-25 at 2.08.31 PM.png (1×1 px, 300 KB)

fa-map on Harbormaster build plans is also used in Drydock resources, maybe confusing?

Didn't catch anything else.

This revision is now accepted and ready to land.Mar 25 2016, 9:10 PM
chad added a comment.Mar 25 2016, 9:18 PM

Do you have icons you'd like to use? Running of out of ideas.

epriestley added a comment.Mar 25 2016, 9:23 PM

Maybe fa-map-signs? Or just fa-ship?

chad updated this revision to Diff 37422.Mar 25 2016, 9:31 PM
chad edited edge metadata.
  • comments
chad added a comment.Mar 25 2016, 9:40 PM

chad added a comment.Mar 25 2016, 9:41 PM

guess i should land it first

Closed by commit rPd76652b33178: Update Harbormaster for two column (authored by chad, committed by chad). · Explain WhyMar 25 2016, 9:41 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Mar 25 2016, 9:42 PM

whoops

chad added a comment.Mar 25 2016, 9:45 PM

pasted_file (270×908 px, 64 KB)

Revision Contents
Changeset List

Diff 37424

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterLintMessagesController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterStepAddController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterStepEditController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterStepViewController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterUnitMessageListController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterUnitMessageViewController.php

Loading...
View Options

src/applications/harbormaster/view/HarbormasterUnitSummaryView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-timeline-view.css

Loading...
Phabricator · Built by Phacility