Differential D15517

Properly extract GitHub event comment text
AcceptedPublic
Actions

Authored by epriestley on Mar 24 2016, 1:28 PM.

Details

Reviewers

chad

Maniphest Tasks

T10538: Bridge GitHub to Phabricator

Summary

Ref T10538. This extracts body text from comment events.

Test Plan

Ran unit tests.

Diff Detail

Repository

rP Phabricator

Branch

nuance24

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11272
Build 14007: Run Core Tests
Build 14006: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37409.Mar 24 2016, 1:28 PM

epriestley retitled this revision from to Properly extract GitHub event comment text.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10538: Bridge GitHub to Phabricator.

Herald edited edge metadata. · View Herald TranscriptMar 24 2016, 1:28 PM

wub wub

This revision is now accepted and ready to land.Mar 24 2016, 3:14 PM

• liugev6 added a commit: rP88a966993be1: Ajax commenting on lightbox images.Nov 22 2016, 8:51 AM

epriestley removed a commit: rP88a966993be1: Ajax commenting on lightbox images.Nov 22 2016, 12:09 PM

• TweikerManager added a commit: rP2604c5af55f6: (stable) Promote 2017 Week 4.Jan 29 2017, 10:50 PM

epriestley removed a commit: rP2604c5af55f6: (stable) Promote 2017 Week 4.Jan 29 2017, 10:52 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

nuance/

github/

NuanceGitHubRawEvent.php

14 lines

__tests__/

NuanceGitHubRawEventTestCase.php

1 line

repositoryevents/

IssueCommentEvent.created.pull.txt

3 lines

IssueCommentEvent.created.txt

3 lines

Diff 37409

View Options

src/applications/nuance/github/NuanceGitHubRawEvent.php

View Options

src/applications/nuance/github/tests/NuanceGitHubRawEventTestCase.php

View Options

src/applications/nuance/github/tests/repositoryevents/IssueCommentEvent.created.pull.txt

View Options

src/applications/nuance/github/tests/repositoryevents/IssueCommentEvent.created.txt

Properly extract GitHub event comment textAcceptedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37409

src/applications/nuance/github/NuanceGitHubRawEvent.php

src/applications/nuance/github/__tests__/NuanceGitHubRawEventTestCase.php

src/applications/nuance/github/__tests__/repositoryevents/IssueCommentEvent.created.pull.txt

src/applications/nuance/github/__tests__/repositoryevents/IssueCommentEvent.created.txt

Properly extract GitHub event comment text
AcceptedPublic
Actions

Revision Contents
Changeset List

src/applications/nuance/github/tests/NuanceGitHubRawEventTestCase.php

src/applications/nuance/github/tests/repositoryevents/IssueCommentEvent.created.pull.txt

src/applications/nuance/github/tests/repositoryevents/IssueCommentEvent.created.txt