Page MenuHomePhabricator

Update Phortune for two column, spruce up UI
ClosedPublic

Authored by chad on Mar 23 2016, 5:33 PM.
Tags
None
Referenced Files
F14034004: D15513.diff
Sat, Nov 9, 9:27 PM
F14021568: D15513.diff
Wed, Nov 6, 9:57 AM
F13996102: D15513.id37400.diff
Wed, Oct 23, 6:02 PM
F13995600: D15513.id.diff
Wed, Oct 23, 2:07 PM
F13995572: D15513.id.diff
Wed, Oct 23, 1:58 PM
F13995504: D15513.id37398.diff
Wed, Oct 23, 1:23 PM
F13995454: D15513.id37398.diff
Wed, Oct 23, 12:59 PM
F13995379: D15513.id37400.diff
Wed, Oct 23, 12:29 PM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP881785aba4bc: Update Phortune for two column, spruce up UI
Summary

Moves everything I could find in Phortune to new UI layouts.

Test Plan

Tested every page I could get two, unclear how to test subscriptions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Update Phortune for two column, spruce up UI.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

Only caught minor stuff:

  • "Details" box on subscriptions is a little whack, I can fix this if you can't test it locally:

Screen Shot 2016-03-23 at 10.38.53 AM.png (279×1 px, 36 KB)

  • Cancel button URI on high security checkpoint for managing a subscription is wrong (probably pre-existing, I'll send you a diff).
  • Merchant member would be nice in the sidebar. :3
  • Merchant "Description" is not separate (inconsistent?).

Screen Shot 2016-03-23 at 10.41.58 AM.png (501×1 px, 53 KB)

src/applications/phortune/controller/PhortuneSubscriptionViewController.php
85

Should be setHeaderText() to fix header maybe?

This revision is now accepted and ready to land.Mar 23 2016, 5:45 PM
chad edited edge metadata.
  • updates per commentittoes
This revision was automatically updated to reflect the committed changes.