Page MenuHomePhabricator
Differential D15505

Add very basic item rendering for GitHub events, parse IDs + URIs
ClosedPublic
Actions

Authored by epriestley on Mar 22 2016, 1:43 PM.
Tags
None
Referenced Files
F15462311: D15505.id.diff
Tue, Apr 1, 1:55 PM
F15459493: D15505.id.diff
Mon, Mar 31, 1:32 PM
F15456985: D15505.id37376.diff
Sun, Mar 30, 1:28 PM
F15455016: D15505.diff
Sat, Mar 29, 9:53 PM
F15426872: D15505.id37376.diff
Sun, Mar 23, 11:19 AM
F15424706: D15505.id37376.diff
Sun, Mar 23, 12:03 AM
F15399146: D15505.diff
Mon, Mar 17, 3:05 AM
F15390255: D15505.id.diff
Sat, Mar 15, 6:04 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10538: Bridge GitHub to Phabricator
Commits
Restricted Diffusion Commit
rPa90daf5d3048: Add very basic item rendering for GitHub events, parse IDs + URIs
Summary

Ref T10538. This extracts and renders URIs for GitHub events so we can link to the original thing on GitHub.

Test Plan

Screen Shot 2016-03-22 at 6.38.59 AM.png (1×1 px, 128 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37376.Mar 22 2016, 1:43 PM
epriestley retitled this revision from to Add very basic item rendering for GitHub events, parse IDs + URIs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10538: Bridge GitHub to Phabricator.
Herald edited edge metadata. · View Herald TranscriptMar 22 2016, 1:43 PM
chad accepted this revision.Mar 22 2016, 2:15 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 22 2016, 2:15 PM
Closed by commit rPa90daf5d3048: Add very basic item rendering for GitHub events, parse IDs + URIs (authored by epriestley, committed by epriestley). · Explain WhyMar 22 2016, 10:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37391

View Options

src/applications/nuance/github/NuanceGitHubRawEvent.php

Loading...
View Options

src/applications/nuance/github/__tests__/NuanceGitHubRawEventTestCase.php

Loading...
View Options

src/applications/nuance/github/__tests__/issueevents/assigned.txt

Loading...
View Options

src/applications/nuance/github/__tests__/issueevents/closed.txt

Loading...
View Options

src/applications/nuance/github/__tests__/issueevents/demilestoned.txt

Loading...
View Options

src/applications/nuance/github/__tests__/issueevents/labeled.txt

Loading...
View Options

src/applications/nuance/github/__tests__/issueevents/locked.txt

Loading...
View Options

src/applications/nuance/github/__tests__/issueevents/milestoned.txt

Loading...
View Options

src/applications/nuance/github/__tests__/issueevents/renamed.txt

Loading...
View Options

src/applications/nuance/github/__tests__/issueevents/reopened.txt

Loading...
View Options

src/applications/nuance/github/__tests__/issueevents/unassigned.txt

Loading...
View Options

src/applications/nuance/github/__tests__/issueevents/unlabeled.txt

Loading...
View Options

src/applications/nuance/github/__tests__/issueevents/unlocked.txt

Loading...
View Options

src/applications/nuance/github/__tests__/repositoryevents/IssueCommentEvent.created.pull.txt

Loading...
View Options

src/applications/nuance/github/__tests__/repositoryevents/IssueCommentEvent.created.txt

Loading...
View Options

src/applications/nuance/github/__tests__/repositoryevents/IssuesEvent.closed.txt

Loading...
View Options

src/applications/nuance/github/__tests__/repositoryevents/IssuesEvent.opened.txt

Loading...
View Options

src/applications/nuance/github/__tests__/repositoryevents/IssuesEvent.reopened.txt

Loading...
View Options

src/applications/nuance/github/__tests__/repositoryevents/PullRequestEvent.opened.txt

Loading...
View Options

src/applications/nuance/github/__tests__/repositoryevents/PushEvent.txt

Loading...
View Options

src/applications/nuance/github/__tests__/repositoryevents/WatchEvent.started.txt

Loading...
View Options

src/applications/nuance/item/NuanceGitHubEventItemType.php

Loading...
View Options

src/applications/nuance/item/NuanceItemType.php

Loading...
Phabricator · Built by Phacility