Page MenuHomePhabricator
Differential D15493

Implement DestructibleInterface on GitLFS refs
ClosedPublic
Actions

Authored by epriestley on Mar 18 2016, 2:25 PM.
Tags
None
Referenced Files
F13089853: D15493.diff
Thu, Apr 25, 2:02 AM
Unknown Object (File)
Fri, Apr 19, 4:20 PM
Unknown Object (File)
Wed, Apr 17, 7:34 PM
Unknown Object (File)
Sun, Apr 7, 11:56 PM
Unknown Object (File)
Mar 21 2024, 1:40 PM
Unknown Object (File)
Mar 18 2024, 8:19 AM
Unknown Object (File)
Feb 25 2024, 12:57 AM
Unknown Object (File)
Feb 18 2024, 6:08 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7789: Support Git Large File Storage
Commits
Restricted Diffusion Commit
rP78e36d6b17a5: Implement DestructibleInterface on GitLFS refs
Summary

Ref T7789. Make sure these get cleaned up when a repository is destroyed.

Test Plan
  • Created a new repository.
  • Pushed some LFS data to it.
  • Used bin/remove destroy to nuke it.
  • Verified the LFS stuff was cleaned up and the underlying files were destroyed (SELECT * FROM repository_gitlfsref, etc).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37345.Mar 18 2016, 2:25 PM
epriestley retitled this revision from to Implement DestructibleInterface on GitLFS refs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7789: Support Git Large File Storage.
Herald edited edge metadata. · View Herald TranscriptMar 18 2016, 2:25 PM
chad accepted this revision.Mar 18 2016, 3:58 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 18 2016, 3:58 PM
Closed by commit rP78e36d6b17a5: Implement DestructibleInterface on GitLFS refs (authored by epriestley, committed by epriestley). · Explain WhyMar 18 2016, 4:36 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T7789: Support Git Large File Storage.Mar 19 2016, 8:20 PM

Revision Contents
Changeset List

PathSize
src/
1 line
applications/
repository/
storage/
8 lines
23 lines

Diff 37352

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryGitLFSRef.php

Loading...
Phabricator · Built by Phacility