Page MenuHomePhabricator
Differential D15493

Implement DestructibleInterface on GitLFS refs
ClosedPublic
Actions

Authored by epriestley on Mar 18 2016, 2:25 PM.
Tags
None
Referenced Files
F15446275: D15493.diff
Thu, Mar 27, 6:07 PM
F15430464: D15493.id37352.diff
Mon, Mar 24, 7:48 AM
F15424088: D15493.id37352.diff
Sat, Mar 22, 8:06 PM
F15421056: D15493.id37345.diff
Fri, Mar 21, 8:41 PM
F15419316: D15493.diff
Fri, Mar 21, 5:16 AM
F15419225: D15493.id37352.diff
Fri, Mar 21, 4:35 AM
F15412383: D15493.diff
Wed, Mar 19, 12:47 PM
F15407030: D15493.id.diff
Tue, Mar 18, 3:15 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7789: Support Git Large File Storage
Commits
Restricted Diffusion Commit
rP78e36d6b17a5: Implement DestructibleInterface on GitLFS refs
Summary

Ref T7789. Make sure these get cleaned up when a repository is destroyed.

Test Plan
  • Created a new repository.
  • Pushed some LFS data to it.
  • Used bin/remove destroy to nuke it.
  • Verified the LFS stuff was cleaned up and the underlying files were destroyed (SELECT * FROM repository_gitlfsref, etc).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37345.Mar 18 2016, 2:25 PM
epriestley retitled this revision from to Implement DestructibleInterface on GitLFS refs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7789: Support Git Large File Storage.
Herald edited edge metadata. · View Herald TranscriptMar 18 2016, 2:25 PM
chad accepted this revision.Mar 18 2016, 3:58 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 18 2016, 3:58 PM
Closed by commit rP78e36d6b17a5: Implement DestructibleInterface on GitLFS refs (authored by epriestley, committed by epriestley). · Explain WhyMar 18 2016, 4:36 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T7789: Support Git Large File Storage.Mar 19 2016, 8:20 PM

Revision Contents
Changeset List

PathSize
src/
1 line
applications/
repository/
storage/
8 lines
23 lines

Diff 37352

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryGitLFSRef.php

Loading...
Phabricator · Built by Phacility