Paths

Table of Contentst

Differential D15475

Modularize temporary token types
ClosedPublic
Actions

Authored by epriestley on Mar 16 2016, 12:24 PM.

Tags

None

Referenced Files

	F13080594: D15475.id37309.diff
	Wed, Apr 24, 9:08 AM

	Unknown Object (File)
	Sat, Apr 20, 3:14 AM

	Unknown Object (File)
	Fri, Apr 19, 11:15 PM

	Unknown Object (File)
	Fri, Apr 19, 8:33 AM

	Unknown Object (File)
	Thu, Apr 11, 6:53 PM

	Unknown Object (File)
	Wed, Apr 10, 7:57 PM

	Unknown Object (File)
	Thu, Mar 28, 3:17 PM

	Unknown Object (File)
	Thu, Mar 28, 10:36 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10603: Make AuthTemporaryTokens suitable for use as LFS tokens

Commits

Restricted Diffusion Commit
rPcf15e0de4386: Modularize temporary token types

Summary

Ref T10603. For LFS, we need to issue a new type of temporary token.

This makes the temporary token code modular so applications can add new token types without modifying the Auth application.

(I'm moving slowly here because it impacts authentication.)

Test Plan

Used bin/auth recover to get a one-time token from the CLI.
Used "Forgot your password?" to get a one-time token from the web UI.
Followed the web UI token to initiate a password reset, prompting generation of a password token.
Viewed these tokens in the web UI:

Revoked a token.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37300.Mar 16 2016, 12:24 PM

epriestley retitled this revision from to Modularize temporary token types.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10603: Make AuthTemporaryTokens suitable for use as LFS tokens.

Herald edited edge metadata. · View Herald TranscriptMar 16 2016, 12:24 PM

Split out some unrelated code for a future diff.

Herald edited edge metadata. · View Herald TranscriptMar 16 2016, 12:24 PM

chad accepted this revision.Mar 16 2016, 2:29 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 16 2016, 2:29 PM

Closed by commit rPcf15e0de4386: Modularize temporary token types (authored by epriestley, committed by epriestley). · Explain WhyMar 16 2016, 4:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

6 lines

applications/

auth/

storage/

PhabricatorAuthTemporaryToken.php

28 lines

tokentype/

PhabricatorAuthOneTimeLoginTemporaryTokenType.php

17 lines

PhabricatorAuthPasswordResetTemporaryTokenType.php

17 lines

PhabricatorAuthTemporaryTokenType.php

24 lines

Diff 37309

src/__phutil_library_map__.php

Loading...

src/applications/auth/storage/PhabricatorAuthTemporaryToken.php

Loading...

src/applications/auth/tokentype/PhabricatorAuthOneTimeLoginTemporaryTokenType.php

Loading...

src/applications/auth/tokentype/PhabricatorAuthPasswordResetTemporaryTokenType.php

Loading...

src/applications/auth/tokentype/PhabricatorAuthTemporaryTokenType.php

Loading...