Fix an issue with rendering unit messages for diffs with no buildable
ClosedPublic
Actions

Authored by epriestley on Mar 15 2016, 3:17 PM.

Tags

None

Referenced Files

	F15432857: D15474.id37299.diff
	Mon, Mar 24, 7:58 PM

	F15423857: D15474.id37298.diff
	Sat, Mar 22, 7:01 PM

	F15411495: D15474.id37299.diff
	Wed, Mar 19, 9:20 AM

	F15394990: D15474.id37299.diff
	Mar 16 2025, 2:34 AM

	F15375674: D15474.id37299.diff
	Mar 12 2025, 11:36 PM

	F15338099: D15474.id37298.diff
	Mar 9 2025, 9:21 AM

	F15336426: D15474.id37299.diff
	Mar 8 2025, 6:49 PM

	F15333862: D15474.id37299.diff
	Mar 8 2025, 5:13 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T10591: viewing D8084 on this install results in InvalidArgumentException

Commits

Restricted Diffusion Commit
rP121e68e3adae: Fix an issue with rendering unit messages for diffs with no buildable

Summary

Fixes T10591. This was accidentally reverted in 148a50e48be146b88036032d1cad772d2627da28, probably when resolvign a merge/rebase.

Test Plan

Will push to production.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37298.Mar 15 2016, 3:17 PM

epriestley retitled this revision from to Fix an issue with rendering unit messages for diffs with no buildable.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10591: viewing D8084 on this install results in InvalidArgumentException.

Herald edited edge metadata. · View Herald TranscriptMar 15 2016, 3:17 PM

chad accepted this revision.Mar 15 2016, 3:17 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 15 2016, 3:17 PM

thx!

Closed by commit rP121e68e3adae: Fix an issue with rendering unit messages for diffs with no buildable (authored by epriestley, committed by epriestley). · Explain WhyMar 15 2016, 3:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

4 lines

Diff 37299

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Fix an issue with rendering unit messages for diffs with no buildableClosedPublicActions