Differential D15459

Partially improve threading UI for adjacent inline comments
ClosedPublic
Actions

Authored by epriestley on Mar 11 2016, 12:36 AM.

Details

Reviewers

chad

Maniphest Tasks

T10563: Inline comments displayed on the same line are shown in creation order without regard for threading

Commits

Restricted Diffusion Commit
rP68b468a846c1: Partially improve threading UI for adjacent inline comments

Summary

Ref T10563. This isn't a complete fix, but should make viewing complex inline threads a little more manageable.

This just tries to put stuff in thread order instead of in pure chronological order. We can likely improve the display treatment -- this is a pretty minimal approach, but should improve clarity.

Test Plan

T10563 has a "before" shot. Here's the "after":

Screen Shot 2016-03-10 at 4.33.26 PM.png (676×956 px, 69 KB)

This makes it a bit easier to follow the conversations.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37254.Mar 11 2016, 12:36 AM

epriestley retitled this revision from to Partially improve threading UI for adjacent inline comments.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10563: Inline comments displayed on the same line are shown in creation order without regard for threading.

Herald edited edge metadata. · View Herald TranscriptMar 11 2016, 12:36 AM

epriestley mentioned this in T10563: Inline comments displayed on the same line are shown in creation order without regard for threading.Mar 11 2016, 12:40 AM

chad accepted this revision.Mar 11 2016, 12:50 AM

chad edited edge metadata.

chad added inline comments.

webroot/rsrc/css/application/differential/phui-inline-comment.css
64	maybe margin them over a bit on the left also, so they look threaded?

This revision is now accepted and ready to land.Mar 11 2016, 12:50 AM

Closed by commit rP68b468a846c1: Partially improve threading UI for adjacent inline comments (authored by epriestley, committed by epriestley). · Explain WhyMar 11 2016, 1:40 AM

This revision was automatically updated to reflect the committed changes.

I tried pushing them in but I thought they looked kinda dumb/weird. Feel free to shoot me a diff if you play around with it and come up with something you like, I just wasn't really happy with anything I could come up with.