Page MenuHomePhabricator
Differential D15455

Add a footer to PHUITwoColumnView
ClosedPublic
Actions

Authored by chad on Mar 10 2016, 3:06 AM.
Tags
None
Referenced Files
F14005972: D15455.id37247.diff
Sun, Oct 27, 10:53 PM
F14005971: D15455.id37246.diff
Sun, Oct 27, 10:53 PM
F14004488: D15455.id.diff
Sat, Oct 26, 9:24 PM
F13999951: D15455.diff
Thu, Oct 24, 6:14 PM
F13981933: D15455.id.diff
Sat, Oct 19, 8:02 PM
F13965862: D15455.id37246.diff
Wed, Oct 16, 4:44 AM
F13964929: D15455.id37247.diff
Tue, Oct 15, 10:46 PM
Unknown Object (File)
Fri, Oct 11, 9:14 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPe351eba74469: Add a footer to PHUITwoColumnView
Summary

This allows setting of full-width content underneath the two column, or full column all by itself. Maybe these names are bad.

Test Plan

Using these in Differential / Diffusion conversions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 37246.Mar 10 2016, 3:06 AM
chad retitled this revision from to Add a footer to PHUITwoColumnView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 10 2016, 3:06 AM
epriestley accepted this revision.Mar 10 2016, 3:09 AM
epriestley edited edge metadata.

Is this any different than this?

return $this->newPage()
  ->setBlahBlah(...)
  ->appendChild(
    array(
      $two_column_view,
      $some_more_content,
    ));
This revision is now accepted and ready to land.Mar 10 2016, 3:09 AM
chad added a comment.Mar 10 2016, 3:09 AM

I suppose I can remove ActionList and PropertyList

epriestley added a comment.Mar 10 2016, 3:10 AM

Oh yeah, we probably got rid of all of those.

Go us!

chad added a comment.Mar 10 2016, 3:10 AM

Yes, it has built in page margins. I want to get away from setting margins for each component for different viewports and just use a page layout engine.

epriestley added a comment.Mar 10 2016, 3:10 AM

Ah, makes sense.

chad updated this revision to Diff 37247.Mar 10 2016, 3:16 AM
chad edited edge metadata.
  • remove lots of code
chad added a comment.Mar 10 2016, 3:17 AM

I suppose even this might move to subclassing newPage ? newObjectPage ?

Closed by commit rPe351eba74469: Add a footer to PHUITwoColumnView (authored by chad, committed by chad). · Explain WhyMar 10 2016, 3:18 AM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Mar 10 2016, 3:21 AM

I am trying to think what would make something like a redesign take less work in the future.

Revision Contents
Changeset List

PathSize
src/
view/
phui/
54 lines

Diff 37248

View Options

src/view/phui/PHUITwoColumnView.php

Loading...
Phabricator · Built by Phacility