Page MenuHomePhabricator
Differential D15427

Improve "Land Revision" errors for issues related to staging areas
ClosedPublic
Actions

Authored by epriestley on Mar 7 2016, 4:49 PM.
Tags
None
Referenced Files
F15408052: D15427.id.diff
Tue, Mar 18, 9:08 PM
F15386193: D15427.id37188.diff
Sat, Mar 15, 12:09 AM
F15386192: D15427.id37187.diff
Sat, Mar 15, 12:09 AM
F15386191: D15427.id.diff
Sat, Mar 15, 12:09 AM
F15386190: D15427.diff
Sat, Mar 15, 12:09 AM
F15377005: D15427.id37188.diff
Thu, Mar 13, 7:09 AM
F15336370: D15427.id37188.diff
Sat, Mar 8, 6:45 PM
F15336368: D15427.id37187.diff
Sat, Mar 8, 6:45 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10093: When builds fail because the staging area was not pushed, make the cause clear
Commits
Restricted Diffusion Commit
rP2ddd78647b20: Improve "Land Revision" errors for issues related to staging areas
Summary

Ref T10093. Changes must be pushed to staging before they can be landed from the web.

Test Plan

Changes must be pushed to staging before they can be landed from the web.

Screen Shot 2016-03-07 at 8.45.44 AM.png (1×1 px, 169 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37187.Mar 7 2016, 4:49 PM
epriestley retitled this revision from to Improve "Land Revision" errors for issues related to staging areas.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10093: When builds fail because the staging area was not pushed, make the cause clear.
epriestley mentioned this in T10093: When builds fail because the staging area was not pushed, make the cause clear.Mar 7 2016, 5:27 PM
chad accepted this revision.Mar 7 2016, 5:44 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 7 2016, 5:44 PM
Closed by commit rP2ddd78647b20: Improve "Land Revision" errors for issues related to staging areas (authored by epriestley, committed by epriestley). · Explain WhyMar 7 2016, 8:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
query/
54 lines
drydock/
operation/
104 lines
harbormaster/
storage/
build/
2 lines

Diff 37188

View Options

src/applications/differential/query/DifferentialDiffQuery.php

Loading...
View Options

src/applications/drydock/operation/DrydockLandRepositoryOperation.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Loading...
Phabricator · Built by Phacility