Page MenuHomePhabricator
Differential D15384

Sync up UI with actual policy rules in Phame
ClosedPublic
Actions

Authored by epriestley on Mar 2 2016, 7:44 PM.
Tags
None
Referenced Files
F13088598: D15384.diff
Thu, Apr 25, 1:29 AM
Unknown Object (File)
Thu, Apr 11, 9:00 AM
Unknown Object (File)
Thu, Apr 11, 3:59 AM
Unknown Object (File)
Sat, Mar 30, 4:28 PM
Unknown Object (File)
Mar 20 2024, 6:04 PM
Unknown Object (File)
Mar 4 2024, 7:21 PM
Unknown Object (File)
Mar 4 2024, 9:50 AM
Unknown Object (File)
Mar 4 2024, 9:50 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10504: Phame EditEngine and policy state is inconsistent for "New Blog" button
Commits
Restricted Diffusion Commit
rPe3ed8b5fe1f5: Sync up UI with actual policy rules in Phame
Summary

Fixes T10504. The "Create Blog" buttons weren't generated by EditEngine, but should be, so that the UI and policies are in sync.

Test Plan
  • Viewed blog list as user with and without permission to create blogs. Saw correct button state.
  • Tried to create blogs, saw correct result.
  • Viewed empty state of home, clicked "New Blog" buttons.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37095.Mar 2 2016, 7:44 PM
epriestley retitled this revision from to Sync up UI with actual policy rules in Phame.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10504: Phame EditEngine and policy state is inconsistent for "New Blog" button.
chad accepted this revision.Mar 2 2016, 7:48 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 2 2016, 7:48 PM
Closed by commit rPe3ed8b5fe1f5: Sync up UI with actual policy rules in Phame (authored by epriestley, committed by epriestley). · Explain WhyMar 2 2016, 7:53 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10672: Complete EditEngine implementation in Badges.Mar 25 2016, 7:18 PM

Revision Contents
Changeset List

PathSize
src/
applications/
phame/
application/
4 lines
controller/
33 lines
blog/
37 lines
editor/
14 lines
view/
2 lines

Diff 37096

View Options

src/applications/phame/application/PhabricatorPhameApplication.php

Loading...
View Options

src/applications/phame/controller/PhameHomeController.php

Loading...
View Options

src/applications/phame/controller/blog/PhameBlogListController.php

Loading...
View Options

src/applications/phame/editor/PhameBlogEditEngine.php

Loading...
View Options

src/applications/phame/view/PhameBlogListView.php

Loading...
Phabricator · Built by Phacility