Page MenuHomePhabricator

Filter out some Clover coverage to prevent false positives
ClosedPublic

Authored by Firehed on Feb 24 2016, 8:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 28, 9:21 AM
Unknown Object (File)
Tue, May 27, 11:36 PM
Unknown Object (File)
Tue, May 20, 3:18 AM
Unknown Object (File)
Tue, May 20, 3:17 AM
Unknown Object (File)
Apr 28 2025, 10:15 AM
Unknown Object (File)
Apr 23 2025, 3:21 PM
Unknown Object (File)
Apr 22 2025, 3:42 AM
Unknown Object (File)
Apr 21 2025, 12:37 PM
Subscribers

Details

Summary

Clover reports generated from PHPUnit sometimes give false positives of lines that were not covered by a test that should have actually been not coverable, apparently due to inaccurate static analysis of files that weren't actually executed. This filters coverage reports of files that show no coverage which avoids these false positives. Fixes T10420.

Test Plan

Looked at coverage reports of files before and after the change

Before:

Screen Shot 2016-02-22 at 5.41.51 PM.png (448×780 px, 55 KB)

After:

Screen Shot 2016-02-22 at 5.41.09 PM.png (524×808 px, 73 KB)

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Firehed retitled this revision from to Filter out some Clover coverage to prevent false positives.
Firehed updated this object.
Firehed edited the test plan for this revision. (Show Details)
Firehed added a reviewer: epriestley.
epriestley edited edge metadata.

I added you to Blessed Committers if you want to arc land or "Land Revision" this yourself, or I can pull it if you hit issues (some of the "Land Revision" error reporting is particularly iffy, right now).

This revision is now accepted and ready to land.Feb 24 2016, 8:57 PM
This revision was automatically updated to reflect the committed changes.