Page MenuHomePhabricator
Differential D15343

Filter out some Clover coverage to prevent false positives
ClosedPublic
Actions

Authored by Firehed on Feb 24 2016, 8:55 PM.
Tags
None
Referenced Files
F14074520: D15343.diff
Thu, Nov 21, 7:33 AM
Unknown Object (File)
Sat, Nov 16, 9:21 PM
Unknown Object (File)
Tue, Nov 5, 5:02 PM
Unknown Object (File)
Wed, Oct 23, 11:35 AM
Unknown Object (File)
Oct 22 2024, 1:21 PM
Unknown Object (File)
Oct 21 2024, 8:31 PM
Unknown Object (File)
Oct 21 2024, 3:24 PM
Unknown Object (File)
Oct 20 2024, 4:12 PM
View All Files
Subscribers
aurelijus
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T10420: Code coverage reports from `arc unit` are sometimes inaccurate
Commits
rARC92a93ab8f475: (stable) Promote 2016 Week 9
rARC086f5399bfbb: Filter out some Clover coverage to prevent false positives
Summary

Clover reports generated from PHPUnit sometimes give false positives of lines that were not covered by a test that should have actually been not coverable, apparently due to inaccurate static analysis of files that weren't actually executed. This filters coverage reports of files that show no coverage which avoids these false positives. Fixes T10420.

Test Plan

Looked at coverage reports of files before and after the change

Before:

Screen Shot 2016-02-22 at 5.41.51 PM.png (448×780 px, 55 KB)

After:

Screen Shot 2016-02-22 at 5.41.09 PM.png (524×808 px, 73 KB)

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Firehed updated this revision to Diff 36999.Feb 24 2016, 8:55 PM
Firehed retitled this revision from to Filter out some Clover coverage to prevent false positives.
Firehed updated this object.
Firehed edited the test plan for this revision. (Show Details)
Firehed added a reviewer: epriestley.
Firehed added a task: T10420: Code coverage reports from `arc unit` are sometimes inaccurate.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 24 2016, 8:55 PM
Herald added subscribers: aurelijus, Korvin. · View Herald Transcript
epriestley accepted this revision.Feb 24 2016, 8:57 PM
epriestley edited edge metadata.

I added you to Blessed Committers if you want to arc land or "Land Revision" this yourself, or I can pull it if you hit issues (some of the "Land Revision" error reporting is particularly iffy, right now).

This revision is now accepted and ready to land.Feb 24 2016, 8:57 PM
Closed by commit rARC086f5399bfbb: Filter out some Clover coverage to prevent false positives (authored by Firehed, committed by Firehed). · Explain WhyFeb 24 2016, 8:58 PM
This revision was automatically updated to reflect the committed changes.
Firehed added a comment.Feb 24 2016, 8:59 PM

Thanks!

Revision Contents
Changeset List

PathSize
src/
unit/
parser/
37 lines

Diff 37000

View Options

src/unit/parser/ArcanistPhpunitTestResultParser.php

Loading...
Phabricator · Built by Phacility