Page MenuHomePhabricator

In Maniphest tasks, only move old owner to CC if owner changed
ClosedPublic

Authored by epriestley on Feb 23 2016, 6:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 8:04 PM
Unknown Object (File)
Thu, Mar 21, 6:33 AM
Unknown Object (File)
Feb 13 2024, 11:44 PM
Unknown Object (File)
Feb 13 2024, 11:44 PM
Unknown Object (File)
Feb 6 2024, 5:59 PM
Unknown Object (File)
Feb 6 2024, 5:47 PM
Unknown Object (File)
Jan 25 2024, 11:48 PM
Unknown Object (File)
Jan 23 2024, 1:28 PM
Subscribers
None

Details

Summary

Fixes T10426. When the owner of a task changes, we try to add the old owner to CC so they're kept in the loop.

Currently, we do this unconditionally. This can add the owner as a subscriber when someone didn't change anything, which is confusing.

Instead, only do this if the owner actually changed.

Test Plan
  • With "A" as owner, edited task and saved.
    • Before patch, A was added as subscriber.
    • After patch, A not added.
  • With "A" as owner, changed owner to "B" and saved.
    • Both before and after patch, "A" is added as a subscriber.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to In Maniphest tasks, only move old owner to CC if owner changed.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 23 2016, 6:09 PM
This revision was automatically updated to reflect the committed changes.