Differential D15329

Expose modern `*.search` Conduit endpoints in Almanac
ClosedPublic
Actions

Authored by epriestley on Feb 22 2016, 10:51 PM.

Tags

None

Referenced Files

	F18866657: D15329.diff
	Mon, Nov 3, 6:31 PM

	F18850094: D15329.id.diff
	Thu, Oct 30, 2:26 PM

	F18844582: D15329.diff
	Wed, Oct 29, 6:36 AM

	F18841463: D15329.id36972.diff
	Tue, Oct 28, 9:19 AM

	F18809792: D15329.id.diff
	Oct 19 2025, 4:58 PM

	F18771566: D15329.id36975.diff
	Oct 8 2025, 8:22 PM

	F18767426: D15329.id36972.diff
	Oct 7 2025, 10:32 PM

	F18765428: D15329.diff
	Oct 7 2025, 11:20 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10246: Deploy Drydock in the Phacility cluster
T10411: Modernize Almanac to support EditEngine

Commits

Restricted Diffusion Commit
rPf7d5904e4b53: Expose modern `*.search` Conduit endpoints in Almanac

Summary

Fixes T10411. Ref T10246. There are probably still some rough edges with this, but replace the old-school endpoints with modern ones so we don't unprototype with deprecated stuff.

Test Plan

Made a bunch of calls to the new endpoints with various constraints/attachments.
Created and edited services, devices, interfaces, bindings, and properties on everything.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36972.Feb 22 2016, 10:51 PM

epriestley retitled this revision from to Expose modern `*.search` Conduit endpoints in Almanac.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10411: Modernize Almanac to support EditEngine, T10246: Deploy Drydock in the Phacility cluster.

chad accepted this revision.Feb 22 2016, 11:01 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 22 2016, 11:01 PM

Closed by commit rPf7d5904e4b53: Expose modern `*.search` Conduit endpoints in Almanac (authored by epriestley, committed by epriestley). · Explain WhyFeb 23 2016, 4:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

20 lines

applications/

almanac/

conduit/

AlmanacConduitAPIMethod.php

2 lines

AlmanacDeviceSearchConduitAPIMethod.php

18 lines

AlmanacServiceSearchConduitAPIMethod.php

18 lines

controller/

AlmanacBindingViewController.php

1 line

AlmanacDeviceViewController.php

1 line

AlmanacPropertyController.php

55 lines

AlmanacPropertyDeleteController.php

20 lines

AlmanacPropertyEditController.php

20 lines

AlmanacServiceViewController.php

1 line

engineextension/

AlmanacBindingsSearchEngineAttachment.php

30 lines

AlmanacPropertiesSearchEngineAttachment.php

26 lines

AlmanacSearchEngineAttachment.php

64 lines

query/

AlmanacBindingQuery.php

38 lines

AlmanacDeviceSearchEngine.php

8 lines

AlmanacInterfaceQuery.php

4 lines

AlmanacNetworkQuery.php

2 lines

AlmanacPropertyQuery.php

70 lines

AlmanacQuery.php

24 lines

AlmanacServiceQuery.php

7 lines

AlmanacServiceSearchEngine.php

17 lines

storage/

AlmanacDevice.php

29 lines

AlmanacService.php

31 lines

search/

field/

PhabricatorSearchTextField.php

4 lines

Diff 36975

src/__phutil_library_map__.php

Loading...

src/applications/almanac/conduit/AlmanacConduitAPIMethod.php

Loading...

src/applications/almanac/conduit/AlmanacDeviceSearchConduitAPIMethod.php

Loading...

src/applications/almanac/conduit/AlmanacServiceSearchConduitAPIMethod.php

Loading...

src/applications/almanac/controller/AlmanacBindingViewController.php

Loading...

src/applications/almanac/controller/AlmanacDeviceViewController.php

Loading...

src/applications/almanac/controller/AlmanacPropertyController.php

Loading...

src/applications/almanac/controller/AlmanacPropertyDeleteController.php

Loading...

src/applications/almanac/controller/AlmanacPropertyEditController.php

Loading...

src/applications/almanac/controller/AlmanacServiceViewController.php

Loading...

src/applications/almanac/engineextension/AlmanacBindingsSearchEngineAttachment.php

Loading...

src/applications/almanac/engineextension/AlmanacPropertiesSearchEngineAttachment.php

Loading...

src/applications/almanac/engineextension/AlmanacSearchEngineAttachment.php

Loading...

src/applications/almanac/query/AlmanacBindingQuery.php

Loading...

src/applications/almanac/query/AlmanacDeviceSearchEngine.php

Loading...

src/applications/almanac/query/AlmanacInterfaceQuery.php

Loading...

src/applications/almanac/query/AlmanacNetworkQuery.php

Loading...

src/applications/almanac/query/AlmanacPropertyQuery.php

Loading...

src/applications/almanac/query/AlmanacQuery.php

Loading...

src/applications/almanac/query/AlmanacServiceQuery.php

Loading...

src/applications/almanac/query/AlmanacServiceSearchEngine.php

Loading...

src/applications/almanac/storage/AlmanacDevice.php

Loading...

src/applications/almanac/storage/AlmanacService.php

Loading...

src/applications/search/field/PhabricatorSearchTextField.php

Loading...