Page MenuHomePhabricator
Differential D15328

Restrict PropertyListView width to just DocumentProView
ClosedPublic
Actions

Authored by chad on Feb 22 2016, 7:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 12:38 AM
Unknown Object (File)
Fri, Dec 6, 5:29 AM
Unknown Object (File)
Sat, Nov 30, 3:32 AM
Unknown Object (File)
Sat, Nov 30, 3:32 AM
Unknown Object (File)
Sat, Nov 30, 3:32 AM
Unknown Object (File)
Sat, Nov 30, 3:22 AM
Unknown Object (File)
Fri, Nov 29, 5:44 AM
Unknown Object (File)
Wed, Nov 27, 2:07 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10409: Document-pro CSS rule is bleeding into Diffusion property lists
Commits
Restricted Diffusion Commit
rP023cfbb23af3: Restrict PropertyListView width to just DocumentProView
Summary

Fixes T10409. Long term need to build a proper "PageEngine" of sorts for layouts not needing special magic. For now this just affects a few applications.

Test Plan

View Diffusion, Phriction, Phame, Legalpad, Diviner.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 36970.Feb 22 2016, 7:50 PM
chad retitled this revision from to Restrict PropertyListView width to just DocumentProView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T10409: Document-pro CSS rule is bleeding into Diffusion property lists.
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 22 2016, 7:50 PM
epriestley accepted this revision.Feb 22 2016, 7:50 PM
epriestley edited edge metadata.

kewl thx :3

This revision is now accepted and ready to land.Feb 22 2016, 7:50 PM
Closed by commit rP023cfbb23af3: Restrict PropertyListView width to just DocumentProView (authored by chad, committed by chad). · Explain WhyFeb 22 2016, 7:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
applications/
diviner/
controller/
2 lines
phame/
controller/
post/
1 line
phriction/
controller/
1 line
webroot/
rsrc/
css/
application/
phame/
3 lines
phui/
13 lines

Diff 36971

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diviner/controller/DivinerAtomController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostViewController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionDocumentController.php

Loading...
View Options

webroot/rsrc/css/application/phame/phame.css

Loading...
View Options

webroot/rsrc/css/phui/phui-document-pro.css

Loading...
Phabricator · Built by Phacility