Differential D15317

Set PhabricatorBotWhatsNewHandler internal method visibility to private
AbandonedPublic
Actions

Authored by dereckson on Feb 21 2016, 5:16 AM.

Details

Reviewers: None

Summary

PhabricatorBotWhatsNewHandler::reportNew method isn't used
anywhere else in the code base and so can be private.

Test Plan

Run phabot, write "What's new?" on a channel

Diff Detail

Repository

rP Phabricator

Branch

fix/visibility

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10787
Build 13281: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 36945.Feb 21 2016, 5:16 AM

dereckson retitled this revision from to Set PhabricatorBotWhatsNewHandler internal method visibility to private.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 21 2016, 5:16 AM

Herald added a subscriber: epriestley. · View Herald Transcript

epriestley removed a reviewer: Blessed Reviewers.Feb 24 2016, 5:27 PM

epriestley removed a subscriber: epriestley.

• TweikerManager added a commit: rP2604c5af55f6: (stable) Promote 2017 Week 4.Jan 29 2017, 10:50 PM

epriestley removed a commit: rP2604c5af55f6: (stable) Promote 2017 Week 4.Jan 29 2017, 10:52 PM

PhabricatorBot is now gone.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

daemon/

bot/

handler/

PhabricatorBotWhatsNewHandler.php

2 lines

Diff 36945

View Options

src/infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php

Set PhabricatorBotWhatsNewHandler internal method visibility to privateAbandonedPublicActions