Page MenuHomePhabricator
Differential D15284

Show first 10 branches, then "More Branches" for commits on huge numbers of branches
ClosedPublic
Actions

Authored by epriestley on Feb 16 2016, 10:27 PM.
Tags
None
Referenced Files
F14730752: D15284.diff
Sat, Jan 18, 7:43 AM
F14722173: D15284.id36875.diff
Fri, Jan 17, 11:19 PM
F14717286: D15284.id36878.diff
Fri, Jan 17, 7:30 PM
Unknown Object (File)
Fri, Jan 17, 12:44 AM
Unknown Object (File)
Tue, Dec 31, 5:24 PM
Unknown Object (File)
Sat, Dec 28, 2:23 PM
Unknown Object (File)
Mon, Dec 23, 12:46 AM
Unknown Object (File)
Fri, Dec 20, 11:43 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9562: Show only the first N branches/tags on commits in Diffusion, with a "Show all..." link
Commits
Restricted Diffusion Commit
rPc6d91938e828: Show first 10 branches, then "More Branches" for commits on huge numbers of…
Summary

Fixes T9562. We already do this for tags, but didn't have similar logic for branches. Implement that logic.

Test Plan
  • Set limit to 1, saw "More branches", clicked it, got the correct results.
  • Verified that branch table with no specified commit still works properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36875.Feb 16 2016, 10:27 PM
epriestley retitled this revision from to Show first 10 branches, then "More Branches" for commits on huge numbers of branches.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9562: Show only the first N branches/tags on commits in Diffusion, with a "Show all..." link.
chad accepted this revision.Feb 16 2016, 10:59 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 16 2016, 10:59 PM
Closed by commit rPc6d91938e828: Show first 10 branches, then "More Branches" for commits on huge numbers of… (authored by epriestley, committed by epriestley). · Explain WhyFeb 16 2016, 11:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
16 lines
36 lines
22 lines

Diff 36878

View Options

src/applications/diffusion/controller/DiffusionBranchTableController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitBranchesController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitTagsController.php

Loading...
Phabricator · Built by Phacility