Page MenuHomePhabricator

Don't show un-completeable results in people/project autocomplete
ClosedPublic

Authored by epriestley on Feb 12 2016, 5:10 PM.
Tags
None
Referenced Files
F18811076: D15261.id36826.diff
Mon, Oct 20, 12:51 AM
F18802881: D15261.diff
Fri, Oct 17, 8:45 PM
F18741948: D15261.id.diff
Thu, Oct 2, 4:40 PM
F18602685: D15261.diff
Sep 13 2025, 3:49 PM
F18593070: D15261.diff
Sep 12 2025, 1:50 PM
F18276755: D15261.id.diff
Aug 22 2025, 7:36 PM
F18245607: D15261.diff
Aug 21 2025, 10:13 AM
F18244863: D15261.id36828.diff
Aug 21 2025, 8:25 AM
Subscribers
None

Details

Summary

Fixes T10285.

  • If a result (like a milestone) has no primary hashtag, try to fill in a secondary hashtag.
  • If we can't find any hashtag, don't return the result.

This produces these behaviors:

  • By default, you can't autocomplete milestones.
  • If you give one a hashtag, you can.

We might want to give milestones "special" hashtags eventually (like #xyz/33) but this fixes the confusing/broken behavior in the UI and we can wait for a better use case for letting you autocomplete milestones, I think.

Also, don't try to cycle hashtags when renaming milestones. This was a little inconsistent before.

Test Plan
  • Autocompleted normal projects.
  • Autocompleted milestones with explicit hashtags.
  • No autocomplete entry for milestones with no special hashtags.
  • Used normal typeahead to get tag-less milestones to make sure I didn't break anything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't show un-completeable results in people/project autocomplete.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 12 2016, 6:00 PM
This revision was automatically updated to reflect the committed changes.