Page MenuHomePhabricator

Add "does not match regexp" to Herald
ClosedPublic

Authored by epriestley on Feb 11 2016, 11:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 12:00 AM
Unknown Object (File)
Sun, Mar 24, 11:38 PM
Unknown Object (File)
Sun, Mar 24, 10:37 PM
Unknown Object (File)
Sun, Mar 24, 10:24 PM
Unknown Object (File)
Sun, Mar 24, 9:45 PM
Unknown Object (File)
Sun, Mar 24, 9:08 PM
Unknown Object (File)
Thu, Mar 21, 10:12 PM
Unknown Object (File)
Sun, Mar 17, 9:16 PM
Subscribers
None

Details

Summary

Fixes T10330.

  • Anywhere we support "matches regexp", also allow "does not match regexp". Although you can sometimes write a clever negative regexp, these rules are better expressed with "does not match <simple regexp>" anyway, and sometimes no regexp will work.
  • Always allow "does not contain" when we support "contains".
  • Fix some JS issues with certain rules affecting custom fields.
Test Plan
  • Wrote an "Affected files do not match regexp" rule that required every diff to touch "MANUALCHANGELOG.md".
  • Tried to diff without the file; rejected.
  • Tried to diff with the file; accepted.
  • Wrote a bunch of "contains" and "does not contain" rules against text fields and custom fields, then edited tasks to trigger/observe them.
  • Swapped the editor into custom text, user, remarkup, etc fields, no more JS errors.

Screen Shot 2016-02-11 at 3.17.21 PM.png (509×1 px, 68 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add "does not match regexp" to Herald.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 11 2016, 11:22 PM
This revision was automatically updated to reflect the committed changes.