Page MenuHomePhabricator

New People Hovercards
ClosedPublic

Authored by chad on Feb 11 2016, 10:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 7:16 PM
Unknown Object (File)
Wed, Dec 18, 6:20 AM
Unknown Object (File)
Wed, Dec 18, 6:20 AM
Unknown Object (File)
Wed, Dec 18, 6:20 AM
Unknown Object (File)
Fri, Dec 6, 3:06 AM
Unknown Object (File)
Sat, Nov 30, 12:25 AM
Unknown Object (File)
Nov 19 2024, 5:09 AM
Unknown Object (File)
Nov 18 2024, 2:14 AM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP6ae0a62f9f48: New People Hovercards
Summary

Mimics the Project Hovercards, more custom UI.

Test Plan

Hover over person with and without badges, hover over project.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to New People Hovercards.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/people/engineextension/PeopleHovercardEngineExtension.php
33

Mostly for completeness: we could load badges here to possibly save a few queries, but I'm pretty sure we never actually bulk-render hovercards right now. But if we swap to a system where you can "View Results As: Hovecards" or have dashboards panels or something like that on list views, we should clean this up if we remember.

Probably we won't, but I'll catch it on an XHProf profile and remember writing this inline and then know where to look to fix it.

src/applications/people/view/PhabricatorUserCardView.php
20–23

(Do we need this? Big plans?)

This revision is now accepted and ready to land.Feb 11 2016, 11:33 PM
src/applications/people/view/PhabricatorUserCardView.php
20–23

This is if we render the card directly on a page, it can be wrapped in an anchor instead of a div. I also used it for testing.

This revision was automatically updated to reflect the committed changes.