Page MenuHomePhabricator

Don't adjust task priority after a workboard drag unless we need to
ClosedPublic

Authored by epriestley on Feb 10 2016, 11:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 10:18 AM
Unknown Object (File)
Mon, Mar 25, 1:38 AM
Unknown Object (File)
Mon, Mar 25, 1:38 AM
Unknown Object (File)
Mon, Mar 25, 1:24 AM
Unknown Object (File)
Mon, Mar 25, 12:39 AM
Unknown Object (File)
Thu, Mar 7, 4:07 AM
Unknown Object (File)
Feb 20 2024, 11:17 AM
Unknown Object (File)
Feb 7 2024, 10:42 PM
Subscribers
None

Details

Summary

Fixes T8197. Currently, if you priority-sort a workboard and drag a card to the top or bottom, we change the priority even if we do not need to.

For example, if the lowest priority in a column is "Low", and you drag a "Wishlist" task underneath it, we incorrectly increase the priority of the task to "Low", when we do not actually need to touch it. This is bad/confusing.

A similar thing happens when dragging a "High" priority task to the top of a column where the highest priority is currently "Normal".

Test Plan
  • Create a column with a "Normal" task.
  • Sort workboard by Priority.
  • Drag a "High" task above it. After patch: task still "High".
  • Drag a "Wishlist" task below it. After patch: task still "Wishlist".

Also dragged a ton of tasks into the middle of other tasks.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't adjust task priority after a workboard drag unless we need to.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 10 2016, 11:46 PM
This revision was automatically updated to reflect the committed changes.