Fixes T10310. This replaces the "Hide Column" / "Show Column" option for milestone columns with one that archives/unarchives, and hides milestone columns when the milestone project is archived.
Details
Details
- Reviewers
hach-que chad - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T10310: Column Name is Required exception when trying to hide a Milestone Column
- Commits
- Restricted Diffusion Commit
rP2f054edfa22e: Hide milestone columns when milestone is archived
- Hid and unhid a normal column (got normal dialogs).
- Hid and unhid a milestone column (got "archive project" dialogs, underlying project archived/unarchived, column vanished).
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
@epriestley I might not get a chance to land this myself, so feel free to land it if you accept it.
Comment Actions
I like this behavior, but want to change the patch a little bit. In particular:
- I think we can just put this logic in $column->isHidden() to simplify things a little bit (IIRC, that already has some other logic).
- I want to leave the "Hide" action present in the menu, but disable it and let the user select it for an explanation of why it's not available.
Lemme steal this and do those bits.
Comment Actions
I guess we could also make "Hide Column" work and mean "Archive Project". Maaaybe I'll just do that? I'm worried that it may be a little surprising, but there's no real cost to undoing it and it's probably better than getting a dialog telling you to go somewhere else to do the thing you wanted to do.
Comment Actions
- Put logic in isHidden().
- Continue showing "Hide Column" and "Show Column" on these columns.
- When the user selects these actions, explain that visibility is tied to subproject status and let them archive/unarchive.