Page MenuHomePhabricator

Fix two minor points UI issues
ClosedPublic

Authored by epriestley on Feb 9 2016, 12:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:37 AM
Unknown Object (File)
Fri, Apr 19, 2:24 AM
Unknown Object (File)
Fri, Apr 19, 2:24 AM
Unknown Object (File)
Fri, Apr 19, 2:24 AM
Unknown Object (File)
Sun, Apr 14, 10:48 PM
Unknown Object (File)
Thu, Apr 11, 9:54 AM
Unknown Object (File)
Thu, Apr 11, 3:44 AM
Unknown Object (File)
Sun, Mar 31, 8:38 PM
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4427: Add formal task points
Commits
Restricted Diffusion Commit
rPaa6c99384879: Fix two minor points UI issues
Summary

Ref T4427.

  • When points are configured, show them on the task detail page (just a simple property, at least for now).
  • Typecast points better to avoid "joe changed points from 12 to 12." beacuse we compare the stored value (as a string) to the new value (as a double).
Test Plan
  • Saw points on detail view.
  • Created task with points, then edited it without touching points. No more spurious "changed from 12 to 12" transaction.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix two minor points UI issues.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 9 2016, 2:25 PM
This revision was automatically updated to reflect the committed changes.