Page MenuHomePhabricator

Support enabling a formal points field in Maniphest
ClosedPublic

Authored by epriestley on Feb 9 2016, 12:07 AM.
Tags
None
Referenced Files
F15542328: D15220.id36743.diff
Fri, Apr 25, 4:31 PM
F15523448: D15220.id36742.diff
Mon, Apr 21, 1:24 AM
F15523318: D15220.id36740.diff
Mon, Apr 21, 12:35 AM
F15514923: D15220.id36743.diff
Fri, Apr 18, 6:40 AM
F15490895: D15220.id36742.diff
Fri, Apr 11, 9:32 PM
F15489960: D15220.id36743.diff
Fri, Apr 11, 1:45 PM
F15476239: D15220.diff
Mon, Apr 7, 4:46 AM
F15466094: D15220.id36740.diff
Thu, Apr 3, 1:30 AM
Subscribers
None

Details

Summary

Ref T4427.

  • New config option for labels, enabling, etc., but no UI/niceness yet.
  • When enabled, add a field.
  • Allow nonnegative values, including fractional values.
  • EditEngine is nice and Conduit / actions basically just work with a tiny bit of extra support code.
Test Plan
  • Edited points via "Edit".
  • Edited points via Conduit.
  • Edited points via stacked actions.
  • Tried to set "zebra" points.
  • Tried to set -1 points.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Support enabling a formal points field in Maniphest.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

This doesn't do anything on projects/workboards yet, that'll be coming soon.

chad edited edge metadata.
This revision is now accepted and ready to land.Feb 9 2016, 2:10 AM
src/aphront/AphrontRequest.php
200 ↗(On Diff #36740)

readImage.jpg (323×575 px, 25 KB)

src/aphront/AphrontRequest.php
200 ↗(On Diff #36740)

oh well you see

it's complicated

shhhh

epriestley edited edge metadata.
  • No random newline in unrelated file.
This revision was automatically updated to reflect the committed changes.