Ref T10288.
I couldn't figure out how to reasonably get the interior right borders to round like the mock, but I think this is otherwise mostly faithful. Feel free to fix stuff.
Differential D15219
First cut of progress bars (PHUISegmentBarView) epriestley on Feb 8 2016, 11:01 PM. Authored by Tags None Referenced Files
Subscribers None
Details
Ref T10288. I couldn't figure out how to reasonably get the interior right borders to round like the mock, but I think this is otherwise mostly faithful. Feel free to fix stuff.
Diff Detail
Event TimelineComment Actions I think we could possibly do something like this without z-index:
I believe that will make them layer correctly, although we might need to render them backward (rightmost bar first). However, I don't really love the added complexity of adding up all the previous bars -- it's nice that we don't have to do that with this approach. But maybe this is sort of moot, it probably won't really make eventual JS layout particularly more complex. I think the rounded stuff might also make, like "1" and "2" look only slightly different (i.e., "1" will be ~5px wide with a chunk out of it, "2" will be ~6px wide with a chunk out of it) which might be hard to read, although maybe not a big deal. Comment Actions
Comment Actions We can go back to the other thing if we run into trouble with this, but I think it's probably OK. |