Page MenuHomePhabricator
Differential D15216

Remove three ancient columns from Maniphest tasks: attached, projectPHIDs, ccPHIDs
ClosedPublic
Actions

Authored by epriestley on Feb 8 2016, 8:24 PM.
Tags
None
Referenced Files
F14044403: D15216.id36730.diff
Tue, Nov 12, 4:00 PM
F13976542: D15216.diff
Oct 18 2024, 2:43 PM
F13970287: D15216.id.diff
Oct 17 2024, 6:44 AM
Unknown Object (File)
Oct 2 2024, 1:28 AM
Unknown Object (File)
Sep 19 2024, 10:22 AM
Unknown Object (File)
Sep 19 2024, 10:12 AM
Unknown Object (File)
Sep 18 2024, 5:28 AM
Unknown Object (File)
Sep 6 2024, 2:06 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP32225d1dd0f8: Remove three ancient columns from Maniphest tasks: attached, projectPHIDs…
Summary

Before edges, we stored some of this stuff directly on tasks.

  • attached was migrated to edges in Jan 2013.
  • projectPHIDs was never used, as far as I can tell?
  • ccPHIDs was migrated away and dropped more than a year ago.

None of these columns are used in modern code (instead, modern code uses edges).

Test Plan

grep, browsed around, bin/storage upgrade, unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36730.Feb 8 2016, 8:24 PM
epriestley retitled this revision from to Remove three ancient columns from Maniphest tasks: attached, projectPHIDs, ccPHIDs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Feb 8 2016, 8:38 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 8 2016, 8:38 PM
Closed by commit rP32225d1dd0f8: Remove three ancient columns from Maniphest tasks: attached, projectPHIDs… (authored by epriestley, committed by epriestley). · Explain WhyFeb 8 2016, 10:10 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D15315: Redesign PonderQuestionView.Feb 23 2016, 2:01 PM

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
2 lines
patches/
28 lines
27 lines
src/
applications/
maniphest/
storage/
17 lines

Diff 36734

View Options

resources/sql/autopatches/20160208.task.1.sql

Loading...
View Options

resources/sql/autopatches/20160208.task.2.sql

Loading...
View Options

resources/sql/patches/migrate-maniphest-dependencies.php

Loading...
View Options

resources/sql/patches/migrate-maniphest-revisions.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTask.php

Loading...
Phabricator · Built by Phacility