Page MenuHomePhabricator

Make waving cover files around on boards more reliable
ClosedPublic

Authored by epriestley on Feb 7 2016, 11:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 4:02 PM
Unknown Object (File)
Mon, Dec 9, 7:52 AM
Unknown Object (File)
Sat, Dec 7, 7:52 PM
Unknown Object (File)
Thu, Dec 5, 2:01 AM
Unknown Object (File)
Tue, Dec 3, 8:02 AM
Unknown Object (File)
Sun, Dec 1, 1:55 PM
Unknown Object (File)
Wed, Nov 27, 5:42 AM
Unknown Object (File)
Fri, Nov 22, 4:33 PM
Subscribers
None

Details

Summary

Currently, in Safari, if you drag an image onto a board to make it a cover file and then wave it around wildly a lot over differnent cards, it sometimes glitches out a bit and won't drop on them properly.

This appears to be because sequencing and delivery of dragenter/dragleave events isn't always totally ideal.

Instead, just cancel any existing drag when we get a new drag that targets a new drop target.

Test Plan
  • Opened a board with a bunch of cards.
  • Dragged a file from my desktop onto the board.
  • Waved it around wildly, hovering over many different cards.
    • Before patch: sometimes cards under the cursor stopped highlighting properly.
    • After patch: behavior seems correct and consistent.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make waving cover files around on boards more reliable.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 7 2016, 11:16 PM
This revision was automatically updated to reflect the committed changes.