Page MenuHomePhabricator
Differential D15205

Make printing workboards work OK
ClosedPublic
Actions

Authored by epriestley on Feb 7 2016, 4:32 AM.
Tags
None
Referenced Files
F14057680: D15205.id.diff
Sun, Nov 17, 5:50 AM
F14005878: D15205.id.diff
Sun, Oct 27, 9:14 PM
F14003820: D15205.diff
Sat, Oct 26, 11:13 AM
F13999030: D15205.id36707.diff
Thu, Oct 24, 12:29 PM
F13976076: D15205.id.diff
Oct 18 2024, 12:46 PM
Unknown Object (File)
Sep 9 2024, 4:03 PM
Unknown Object (File)
Sep 4 2024, 1:17 AM
Unknown Object (File)
Sep 1 2024, 4:32 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7844: Workboard printable is incomplete/empty
Commits
Restricted Diffusion Commit
rP73f5ff065929: Make printing workboards work OK
Summary

Fixes T7844. This isn't going to win any awards, but it has all the information.

Mostly, we don't (or shouldn't, at least?) need the global static stuff anymore because we dropped the top-level custom scrollbar.

Test Plan

Printed a PDF of a workboard, got all the cards in the output.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36706.Feb 7 2016, 4:32 AM
epriestley retitled this revision from to Make printing workboards work OK.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7844: Workboard printable is incomplete/empty.
Herald edited edge metadata. · View Herald TranscriptFeb 7 2016, 4:32 AM
epriestley added a comment.Feb 7 2016, 4:32 AM

Here's the PDF:

(635) Stonework · Workboard.pdf149 KBDownload

chad accepted this revision.Feb 7 2016, 4:37 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 7 2016, 4:37 AM
epriestley added inline comments.Feb 7 2016, 4:38 AM
webroot/rsrc/css/phui/workboards/phui-workboard.css
62

I also verified that this 100% works with 100% of everything by typing it into caniuse.com

Closed by commit rP73f5ff065929: Make printing workboards work OK (authored by epriestley, committed by epriestley). · Explain WhyFeb 7 2016, 4:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
14 lines
webroot/
rsrc/
css/
application/
base/
12 lines
phui/
4 lines
workboards/
10 lines

Diff 36707

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/base/standard-page-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-profile-menu.css

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workboard.css

Loading...
Phabricator · Built by Phacility