Page MenuHomePhabricator
Differential D15202

Support drag-and-drop to set cover images on workboard cards
ClosedPublic
Actions

Authored by epriestley on Feb 6 2016, 11:37 PM.
Tags
None
Referenced Files
F15471028: D15202.id36700.diff
Sat, Apr 5, 2:58 AM
F15455869: D15202.id36700.diff
Sun, Mar 30, 5:25 AM
F15455157: D15202.id36699.diff
Sat, Mar 29, 10:34 PM
F15453435: D15202.id.diff
Sat, Mar 29, 11:46 AM
F15450556: D15202.diff
Fri, Mar 28, 4:27 PM
F15435411: D15202.diff
Tue, Mar 25, 8:07 AM
F15432070: D15202.id36700.diff
Mon, Mar 24, 3:59 PM
F15414657: D15202.id36700.diff
Thu, Mar 20, 1:50 AM
View All Files
Subscribers
None
Tokens
"Like" token, awarded by chad.

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP78c248d33024: Support drag-and-drop to set cover images on workboard cards
Summary

This was slightly more complex than I believed, but not too terrible.

Test Plan

Screen Shot 2016-02-06 at 3.32.45 PM.png (1×2 px, 247 KB)

  • Also used some normal file uploaders to make sure I didn't break that.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36699.Feb 6 2016, 11:37 PM
epriestley retitled this revision from to Support drag-and-drop to set cover images on workboard cards.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald edited edge metadata. · View Herald TranscriptFeb 6 2016, 11:37 PM
chad awarded a token.Feb 6 2016, 11:51 PM
epriestley added a comment.Feb 6 2016, 11:53 PM

The active drop state looks a little weird to me, feel free to gussy it up if you have any ideas.

webroot/rsrc/css/phui/workboards/phui-workcard.css
109–111

(This thing.)

chad accepted this revision.Feb 6 2016, 11:58 PM
chad edited edge metadata.

Doitlive

This revision is now accepted and ready to land.Feb 6 2016, 11:58 PM
Closed by commit rP78c248d33024: Support drag-and-drop to set cover images on workboard cards (authored by epriestley, committed by epriestley). · Explain WhyFeb 6 2016, 11:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
builtin/
celerity/
65 lines
src/
2 lines
applications/
maniphest/
editor/
79 lines
storage/
4 lines
4 lines
project/
application/
1 line
controller/
3 lines
49 lines
53 lines
37 lines
webroot/
rsrc/
css/
phui/
workboards/
4 lines
js/
application/
projects/
34 lines
core/
161 lines
1 line

Diff 36700

View Options

resources/builtin/image-526x526.png

Loading...
View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTask.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTransaction.php

Loading...
View Options

src/applications/project/application/PhabricatorProjectApplication.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectCoverController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectMoveController.php

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workcard.css

Loading...
View Options

webroot/rsrc/js/application/projects/behavior-project-boards.js

Loading...
View Options

webroot/rsrc/js/core/DragAndDropFileUpload.js

Loading...
View Options

webroot/rsrc/js/core/FileUpload.js

Loading...
Phabricator · Built by Phacility