Add storage and read logic for workboard card cover photos
ClosedPublic
Actions

Authored by epriestley on Feb 6 2016, 9:46 PM.

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rPb6a38b403cbf: Add storage and read logic for workboard card cover photos

Summary

No way to set photos yet, but if you magic them in they work.

Primarily, this consolidates rendering logic so the move + edit + view controllers all run the same code to do tags / cover photos.

Test Plan

Screen Shot 2016-02-06 at 1.35.40 PM.png (1×2 px, 515 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36697.Feb 6 2016, 9:46 PM

epriestley retitled this revision from to Add storage and read logic for workboard card cover photos.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Feb 6 2016, 9:52 PM

chad edited edge metadata.

chad added inline comments.

src/applications/files/transform/PhabricatorFileThumbnailTransform.php
77	new self?

This revision is now accepted and ready to land.Feb 6 2016, 9:52 PM

There's a lint rule that corrects X to self when X is the current class. Most of the time I think it's good on the balance. I'm not totally sold on new self() which is a little weird, but it's consistent with self::CLASS_CONST and that one is usually preferred, I think.