Page MenuHomePhabricator
Differential D15191

Improve type and icon information in typeahead
ClosedPublic
Actions

Authored by epriestley on Feb 5 2016, 8:45 PM.
Tags
None
Referenced Files
F15475686: D15191.id36672.diff
Sun, Apr 6, 9:39 PM
F15463695: D15191.id.diff
Wed, Apr 2, 2:12 AM
F15463096: D15191.id36672.diff
Tue, Apr 1, 8:13 PM
F15460147: D15191.diff
Mon, Mar 31, 8:37 PM
F15445096: D15191.id36672.diff
Thu, Mar 27, 12:26 PM
F15416939: D15191.id36672.diff
Thu, Mar 20, 2:26 PM
F15413054: D15191.diff
Wed, Mar 19, 4:44 PM
F15411942: D15191.id36673.diff
Wed, Mar 19, 10:27 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10289: Clarify project type in search typeahead
Commits
Restricted Diffusion Commit
rP4132ba0853e9: Improve type and icon information in typeahead
Summary

Ref T10289. This probably doesn't cover everything but should do a little bit better.

Although we should mabye just exlude milestones from this menu completely?

Test Plan

Screen Shot 2016-02-05 at 12.44.49 PM.png (232×340 px, 19 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36672.Feb 5 2016, 8:45 PM
epriestley retitled this revision from to Improve type and icon information in typeahead.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10289: Clarify project type in search typeahead.
epriestley added a comment.Feb 5 2016, 8:46 PM

Even if we drop milestones out of this menu I think this is still an improvement for other projects given that we're giving icons stronger types now.

chad edited edge metadata.Feb 5 2016, 8:47 PM

I like it! (for milestones also, I keep using search to get to Projects (v3))

chad accepted this revision.Feb 5 2016, 8:47 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 5 2016, 8:47 PM
Closed by commit rP4132ba0853e9: Improve type and icon information in typeahead (authored by epriestley, committed by epriestley). · Explain WhyFeb 5 2016, 8:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
27 lines
src/
applications/
diffusion/
typeahead/
5 lines
project/
storage/
2 lines
typeahead/
2 lines
webroot/
rsrc/
js/
core/
11 lines

Diff 36673

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/typeahead/DiffusionSymbolDatasource.php

Loading...
View Options

src/applications/project/storage/PhabricatorProject.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectDatasource.php

Loading...
View Options

webroot/rsrc/js/core/behavior-search-typeahead.js

Loading...
Phabricator · Built by Phacility