Fix mishandling of chunk threshold in Diffusion for installs with no chunk engines available
ClosedPublic
Actions

Authored by epriestley on Feb 3 2016, 10:45 PM.

Details

Reviewers

chad

Maniphest Tasks

T10273: Viewing any file (regardless of size) in Diffusion throws Unhandled Exception.

Commits

Restricted Diffusion Commit
rP68254a046ff0: Fix mishandling of chunk threshold in Diffusion for installs with no chunk…

Summary

Fixes T10273. The threshold is null if no chunk engines are available, but the code didn't handle this properly.

Test Plan

Disabled all chunk engines, reloaded, hit issue described in task. Applied patch, got clean file content.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36638.Feb 3 2016, 10:45 PM

epriestley retitled this revision from to Fix mishandling of chunk threshold in Diffusion for installs with no chunk engines available.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10273: Viewing any file (regardless of size) in Diffusion throws Unhandled Exception..

chad accepted this revision.Feb 3 2016, 10:46 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 3 2016, 10:46 PM

Closed by commit rP68254a046ff0: Fix mishandling of chunk threshold in Diffusion for installs with no chunk… (authored by epriestley, committed by epriestley). · Explain WhyFeb 3 2016, 10:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

uploadsource/

PhabricatorFileUploadSource.php

30 lines

Diff 36639

View Options

src/applications/files/uploadsource/PhabricatorFileUploadSource.php

Fix mishandling of chunk threshold in Diffusion for installs with no chunk engines availableClosedPublicActions