Page MenuHomePhabricator
Differential D15161

Make all CSS rules for draggable cards/items independent of container classes
ClosedPublic
Actions

Authored by epriestley on Feb 2 2016, 1:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 3:21 AM
Unknown Object (File)
Tue, Dec 10, 5:00 PM
Unknown Object (File)
Sat, Dec 7, 5:56 AM
Unknown Object (File)
Tue, Nov 26, 8:18 PM
Unknown Object (File)
Nov 20 2024, 6:40 PM
Unknown Object (File)
Nov 19 2024, 8:09 PM
Unknown Object (File)
Nov 16 2024, 3:15 PM
Unknown Object (File)
Nov 11 2024, 8:33 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T5240: Dragging items (cards, panels) could be better in Workboards
Commits
Restricted Diffusion Commit
rPffb7978528e4: Make all CSS rules for draggable cards/items independent of container classes
Summary

Ref T5240. With the new approach, the draggable clones lose their containers, so they don't get affected by rules like .container .item.

Put classes on the cards/items and use .board-item.item and .standard-item.item to apply rules instead.

This didn't turn out too gross, and seems relatively OK / not obviously broken.

Test Plan
  • Dragged cards on a workboard.
  • Dragged items in normal lists (tasks, pinned apps).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36602.Feb 2 2016, 1:49 AM
epriestley retitled this revision from to Make all CSS rules for draggable cards/items independent of container classes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T5240: Dragging items (cards, panels) could be better in Workboards.
Herald edited edge metadata. · View Herald TranscriptFeb 2 2016, 1:49 AM
epriestley updated this revision to Diff 36603.Feb 2 2016, 1:50 AM
epriestley edited edge metadata.
  • Small fix for Maniphest.
Herald edited edge metadata. · View Herald TranscriptFeb 2 2016, 1:50 AM
chad accepted this revision.Feb 2 2016, 2:12 AM
chad edited edge metadata.
chad added inline comments.
webroot/rsrc/css/phui/phui-object-item-list-view.css
377

Should probably move this rule to phui-workcard

This revision is now accepted and ready to land.Feb 2 2016, 2:12 AM
Closed by commit rPffb7978528e4: Make all CSS rules for draggable cards/items independent of container classes (authored by epriestley, committed by epriestley). · Explain WhyFeb 2 2016, 2:48 AM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Feb 2 2016, 4:49 AM

one thing I noticed is that phui-workcard doesn't get added after the clone is dropped. If I add it manually it looks fine. I can dig into it tomorrow, everything else looks great.

chad added a comment.Feb 2 2016, 5:08 AM

Other small nits:

  • If there is only one column, I can only drag inside that column. vs anywhere if there are two column.
  • Tooltips for usernames fire when dragging cards around
epriestley added a comment.Feb 2 2016, 5:15 AM

one thing I noticed is that phui-workcard doesn't get added after the clone is dropped. If I add it manually it looks fine.

Oh, good catch. I'm pretty sure I know what's up.

Other stuff should be pretty easy to fix.

epriestley added a comment.Feb 2 2016, 5:16 AM

I'll move that rule too, just slipped my mind when I was arc land'ing.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
project/
controller/
1 line
view/
phui/
11 lines
webroot/
rsrc/
css/
phui/
9 lines
workboards/
58 lines

Diff 36605

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/view/phui/PHUIObjectItemListView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workcard.css

Loading...
Phabricator · Built by Phacility