Paths

Table of Contentst

Differential D15161

Make all CSS rules for draggable cards/items independent of container classes
ClosedPublic
Actions

Authored by epriestley on Feb 2 2016, 1:49 AM.

Tags

None

Referenced Files

	F14055731: D15161.diff
	Sat, Nov 16, 3:15 PM

	F14041683: D15161.diff
	Mon, Nov 11, 8:33 PM

	F14025555: D15161.diff
	Thu, Nov 7, 6:49 PM

	F13997585: D15161.diff
	Thu, Oct 24, 5:16 AM

	F13961039: D15161.id36602.diff
	Oct 15 2024, 2:47 AM

	Unknown Object (File)
	Sep 29 2024, 12:04 PM

	Unknown Object (File)
	Sep 12 2024, 7:31 AM

	Unknown Object (File)
	Sep 12 2024, 7:30 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T5240: Dragging items (cards, panels) could be better in Workboards

Commits

Restricted Diffusion Commit
rPffb7978528e4: Make all CSS rules for draggable cards/items independent of container classes

Summary

Ref T5240. With the new approach, the draggable clones lose their containers, so they don't get affected by rules like .container .item.

Put classes on the cards/items and use .board-item.item and .standard-item.item to apply rules instead.

This didn't turn out too gross, and seems relatively OK / not obviously broken.

Test Plan

Dragged cards on a workboard.
Dragged items in normal lists (tasks, pinned apps).

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36602.Feb 2 2016, 1:49 AM

epriestley retitled this revision from to Make all CSS rules for draggable cards/items independent of container classes.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T5240: Dragging items (cards, panels) could be better in Workboards.

Herald edited edge metadata. · View Herald TranscriptFeb 2 2016, 1:49 AM

Small fix for Maniphest.

Herald edited edge metadata. · View Herald TranscriptFeb 2 2016, 1:50 AM

chad accepted this revision.Feb 2 2016, 2:12 AM

chad edited edge metadata.

chad added inline comments.

webroot/rsrc/css/phui/phui-object-item-list-view.css
377	Should probably move this rule to phui-workcard

This revision is now accepted and ready to land.Feb 2 2016, 2:12 AM

Closed by commit rPffb7978528e4: Make all CSS rules for draggable cards/items independent of container classes (authored by epriestley, committed by epriestley). · Explain WhyFeb 2 2016, 2:48 AM

This revision was automatically updated to reflect the committed changes.

one thing I noticed is that phui-workcard doesn't get added after the clone is dropped. If I add it manually it looks fine. I can dig into it tomorrow, everything else looks great.

Other small nits:

If there is only one column, I can only drag inside that column. vs anywhere if there are two column.
Tooltips for usernames fire when dragging cards around

one thing I noticed is that phui-workcard doesn't get added after the clone is dropped. If I add it manually it looks fine.

Oh, good catch. I'm pretty sure I know what's up.

Other stuff should be pretty easy to fix.

I'll move that rule too, just slipped my mind when I was arc land'ing.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

10 lines

src/

applications/

project/

controller/

PhabricatorProjectBoardViewController.php

1 line

view/

phui/

PHUIObjectItemListView.php

11 lines

webroot/

rsrc/

css/

phui/

phui-object-item-list-view.css

9 lines

workboards/

phui-workcard.css

58 lines

Diff 36605

resources/celerity/map.php

Loading...

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...

src/view/phui/PHUIObjectItemListView.php

Loading...

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...

webroot/rsrc/css/phui/workboards/phui-workcard.css

Loading...