Page MenuHomePhabricator
Differential D15154

Always give users "fa-user" icons in tokenizers
ClosedPublic
Actions

Authored by epriestley on Feb 1 2016, 5:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 14, 4:11 AM
Unknown Object (File)
Sun, Feb 9, 12:39 AM
Unknown Object (File)
Sun, Feb 9, 12:38 AM
Unknown Object (File)
Sun, Feb 9, 12:38 AM
Unknown Object (File)
Sun, Feb 9, 12:38 AM
Unknown Object (File)
Thu, Jan 30, 10:25 PM
Unknown Object (File)
Fri, Jan 24, 11:31 AM
Unknown Object (File)
Fri, Jan 24, 11:31 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10247: Don't show custom user icons in typeaheads
Commits
Restricted Diffusion Commit
rP18f34fab7397: Always give users "fa-user" icons in tokenizers
Summary

Fixes T10247. The flavor icons are unhelpful/confusing in these contexts; show a boringer icon instead.

Test Plan

Used tokenizer to select user with custom profile icon. Reloaded page. Saw boringer icon in both cases.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36586.Feb 1 2016, 5:46 PM
epriestley retitled this revision from to Always give users "fa-user" icons in tokenizers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10247: Don't show custom user icons in typeaheads.
chad accepted this revision.Feb 1 2016, 5:48 PM
chad edited edge metadata.

Mmmm Boringer Flavor.

Kent All-750x750.jpg (750×750 px, 669 KB)

This revision is now accepted and ready to land.Feb 1 2016, 5:48 PM
Closed by commit rP18f34fab7397: Always give users "fa-user" icons in tokenizers (authored by epriestley, committed by epriestley). · Explain WhyFeb 1 2016, 5:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
people/
phid/
6 lines
phid/
14 lines
typeahead/
view/
2 lines

Diff 36588

View Options

src/applications/people/phid/PhabricatorPeopleUserPHIDType.php

Loading...
View Options

src/applications/phid/PhabricatorObjectHandle.php

Loading...
View Options

src/applications/typeahead/view/PhabricatorTypeaheadTokenView.php

Loading...
Phabricator · Built by Phacility