Decode "Content-Encoding: gzip" content
ClosedPublic
Actions

Authored by epriestley on Jan 31 2016, 12:46 AM.

Details

Reviewers

chad

Maniphest Tasks

T10228: Switching imported repository to hosted, then cloning over HTTP in Phacility production fails

Commits

Restricted Diffusion Commit
rP71bda66870d8: (stable) Decode "Content-Encoding: gzip" content
rP8269fd6e6c1f: Decode "Content-Encoding: gzip" content

Summary

Fixes T10228. When we receive a gzipped request (rare, but git may send them), decode it before providing it to the application.

This fixes the issue with proxying certain requests described in T10228.

Test Plan

Applied this fix in production.
Cloned a problem repository cleanly.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36566.Jan 31 2016, 12:46 AM

epriestley retitled this revision from to Decode "Content-Encoding: gzip" content.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10228: Switching imported repository to hosted, then cloning over HTTP in Phacility production fails.

shititquick

This revision is now accepted and ready to land.Jan 31 2016, 12:48 AM

Closed by commit rP8269fd6e6c1f: Decode "Content-Encoding: gzip" content (authored by epriestley, committed by epriestley). · Explain WhyJan 31 2016, 12:48 AM

This revision was automatically updated to reflect the committed changes.

er shipitquick

Revision Contents
Changeset List

Path

Size

support/

PhabricatorStartup.php

14 lines

Diff 36568

View Options

support/PhabricatorStartup.php

Decode "Content-Encoding: gzip" contentClosedPublicActions