Page MenuHomePhabricator

Add a basic pull event log for debugging repository cloning
ClosedPublic

Authored by epriestley on Jan 28 2016, 2:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 6:33 AM
Unknown Object (File)
Sun, May 5, 9:10 PM
Unknown Object (File)
Fri, May 3, 4:02 AM
Unknown Object (File)
Mon, Apr 29, 4:19 PM
Unknown Object (File)
Thu, Apr 25, 12:00 AM
Unknown Object (File)
Fri, Apr 19, 5:19 PM
Unknown Object (File)
Fri, Apr 19, 4:09 PM
Unknown Object (File)
Thu, Apr 11, 8:16 AM
Subscribers
None

Details

Summary

Ref T10228. This is currently quite limited:

  • No UI.
  • No SSH support.

My primary goal is to debug the issue in T10228. In the long run we can expand this to be a bit fancier.

Test Plan

Made various valid and invalid clones, got sucess responses and not-so-successful responses, viewed the log table for general corresponding messages and broad sanity.

Ran GC via bin/phd debug trigger, no issues.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add a basic pull event log for debugging repository cloning.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

Although I don't plan to build this out any more than necessary, I'll probably eventually just expose this log (except for IP addresses) to anyone who can see the repository. This feels a little more open than strictly necessary (e.g., it would let me see when you've cloned the repo), but I think it's not really problematic to expose, and justified by the difficulty many users have configuring repository hosting (since we'll be able to give them more information about what went wrong).

We also already have similar rules for the push log. I do think there's a material difference between showing when you edited something (which we always do in all other applications) and when you merely looked at it, but exposing clone activity doesn't feel creepy/weird to me in the same way that read receipts or "who is looking at this page right now" sort of do (maybe because it's almost never socially interesting).

chad edited edge metadata.
This revision is now accepted and ready to land.Jan 28 2016, 2:59 PM
This revision was automatically updated to reflect the committed changes.