Differential D15120

Extend PHUITheme to include Profile Nav
ClosedPublic
Actions

Authored by chad on Jan 27 2016, 9:18 PM.

Tags

None

Referenced Files

	F13214048: D15120.diff
	Fri, May 17, 8:25 AM

	F13198149: D15120.id36510.diff
	Mon, May 13, 4:27 AM

	F13184790: D15120.diff
	Fri, May 10, 11:59 PM

	Unknown Object (File)
	Tue, May 7, 9:53 AM

	Unknown Object (File)
	Fri, May 3, 9:43 AM

	Unknown Object (File)
	Thu, Apr 25, 3:21 AM

	Unknown Object (File)
	Wed, Apr 24, 9:32 AM

	Unknown Object (File)
	Apr 19 2024, 12:30 AM

Subscribers

Details

Reviewers

Commits

Restricted Diffusion Commit
rPc9119306d795: Extend PHUITheme to include Profile Nav

Summary

Reasonable first pass, removes the "light" header, due to pain of upkeep. Reinforces UI color into the Profile Nav (and later likely dropmenu hovers). Most of this is reasonably easy to maintain now, but I may do a more accurate color pass after I get some more time together with it. For now this feels pretty good if you're developing in a different color UI.

Test Plan

Switch between all the colors, hover over all the states.

pasted_file (1×694 px, 195 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 36508.Jan 27 2016, 9:18 PM

chad retitled this revision from to Extend PHUITheme to include Profile Nav.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptJan 27 2016, 9:18 PM

chad edited the test plan for this revision. (Show Details)Jan 27 2016, 9:37 PM

put back white constants

epriestley accepted this revision.Jan 27 2016, 9:46 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 27 2016, 9:46 PM

I think we want to maybe move this stuff into CelerityPostProcessor to allow users to set their own themes?

I don't feel any particular desire to let users set their own themes, but if you want...

Closed by commit rPc9119306d795: Extend PHUITheme to include Profile Nav (authored by chad, committed by chad). · Explain WhyJan 27 2016, 9:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

18 lines

src/

applications/

celerity/

postprocessor/

CelerityDefaultPostprocessor.php

15 lines

config/

option/

PhabricatorUIConfigOptions.php

3 lines

webroot/

rsrc/

css/

application/

base/

92 lines

core/

2 lines

phui/

2 lines

phui-profile-menu.css

18 lines

Diff 36510

resources/celerity/map.php

Loading...

src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php

Loading...

src/applications/config/option/PhabricatorUIConfigOptions.php

Loading...

webroot/rsrc/css/application/base/phui-theme.css

Loading...

webroot/rsrc/css/core/core.css

Loading...

webroot/rsrc/css/phui/phui-box.css

Loading...

webroot/rsrc/css/phui/phui-profile-menu.css

Loading...