Page MenuHomePhabricator

Extend PHUITheme to include Profile Nav
ClosedPublic

Authored by chad on Jan 27 2016, 9:18 PM.
Tags
None
Referenced Files
F17807167: D15120.id.diff
Fri, Jul 25, 2:38 PM
F17763342: D15120.diff
Tue, Jul 22, 11:17 PM
F17657742: D15120.id36508.diff
Sat, Jul 12, 12:32 PM
F17633559: D15120.diff
Thu, Jul 10, 7:00 PM
Unknown Object (File)
Jun 21 2025, 12:38 PM
Unknown Object (File)
Jun 20 2025, 5:47 AM
Unknown Object (File)
Jun 18 2025, 5:12 PM
Unknown Object (File)
Jun 17 2025, 7:39 PM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPc9119306d795: Extend PHUITheme to include Profile Nav
Summary

Reasonable first pass, removes the "light" header, due to pain of upkeep. Reinforces UI color into the Profile Nav (and later likely dropmenu hovers). Most of this is reasonably easy to maintain now, but I may do a more accurate color pass after I get some more time together with it. For now this feels pretty good if you're developing in a different color UI.

Test Plan

Switch between all the colors, hover over all the states.

pasted_file (1×694 px, 195 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Extend PHUITheme to include Profile Nav.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
  • put back white constants
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 27 2016, 9:46 PM

I think we want to maybe move this stuff into CelerityPostProcessor to allow users to set their own themes?

I don't feel any particular desire to let users set their own themes, but if you want...

This revision was automatically updated to reflect the committed changes.