Throw a more tailored error when a `storage upgrade` patch can't access a database
ClosedPublic
Actions

Authored by epriestley on Jan 21 2016, 9:16 PM.

Details

Reviewers

chad

Maniphest Tasks

T8762: Upgrade process should be more informative when unable to create new databases

Commits

Restricted Diffusion Commit
rP5f170847caa8: Throw a more tailored error when a `storage upgrade` patch can't access a…

Summary

Fixes T8762.

Test Plan

Ran bin/storage upgrade --namespace ... --user limited, saw a more specific error.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36410.Jan 21 2016, 9:16 PM

epriestley retitled this revision from to Throw a more tailored error when a `storage upgrade` patch can't access a database.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T8762: Upgrade process should be more informative when unable to create new databases.

epriestley mentioned this in T8752: PhabricatorAuthProviderOAuthGoogle and PhabricatorAuthProviderPassword both show Provider Implementation Missing! .Jan 21 2016, 9:18 PM

chad accepted this revision.Jan 21 2016, 10:09 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 21 2016, 10:09 PM

Closed by commit rP5f170847caa8: Throw a more tailored error when a `storage upgrade` patch can't access a… (authored by epriestley, committed by epriestley). · Explain WhyJan 21 2016, 10:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

storage/

management/

PhabricatorStorageManagementAPI.php

17 lines

Diff 36414

View Options

src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php

Throw a more tailored error when a `storage upgrade` patch can't access a databaseClosedPublicActions