Page MenuHomePhabricator

Fix an issue with paginating queries which reverse vector ordering components
ClosedPublic

Authored by epriestley on Jan 21 2016, 6:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 10:43 PM
Unknown Object (File)
Tue, Apr 23, 3:05 AM
Unknown Object (File)
Mon, Apr 22, 10:25 AM
Unknown Object (File)
Sun, Apr 21, 5:04 AM
Unknown Object (File)
Sat, Apr 13, 10:03 PM
Unknown Object (File)
Thu, Apr 11, 5:17 AM
Unknown Object (File)
Mar 13 2024, 6:55 AM
Unknown Object (File)
Mar 5 2024, 5:27 PM
Subscribers
None

Details

Summary

Ref T10188. If you issue certain queries which use reverse ordering (like "All tasks, oldest update to newest update") and then try to page forward, we build the paging clause without reversing the column order correctly.

For example, the ordering of "oldest update to newest update" is "dateModified ASC, id ASC", so the second page should include an "id > X" query. Currently, this builds as "id < X" incorrectly instead.

The cause of this is just a failure to re-reverse a reversing flag when constructing the paging clause.

Test Plan
  • Queried tasks by update, oldest to newest, with no grouping, etc.
  • Paged to second page.
  • After change, got a valid second page with a good query in the Services tab.
  • Made some other normal queries.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix an issue with paginating queries which reverse vector ordering components.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 21 2016, 6:57 PM
This revision was automatically updated to reflect the committed changes.