Paths

Table of Contentst

Differential D15071

Give PhutilRope and LinesOfALarge a couple new capabilities
ClosedPublic
Actions

Authored by epriestley on Jan 21 2016, 5:21 PM.

Details

Reviewers

chad

Maniphest Tasks

T10186: Landing a diff with files larger than 8M leads to storage engine error

Commits

rPHUb4edc1af066d: Give PhutilRope and LinesOfALarge a couple new capabilities

Summary

Ref T10186. To fix that, I need to stream files out of commands like git cat directly into file storage.

This adds two capabilities to support this:

LinesOfALarge can now just ignore delimiters and stream all the data directly.
PhutilRope can now produce a prefix of a specific length (this is used to produce a chunk-sized prefix).

Test Plan

See next revision.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36392.Jan 21 2016, 5:21 PM

epriestley retitled this revision from to Give PhutilRope and LinesOfALarge a couple new capabilities.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10186: Landing a diff with files larger than 8M leads to storage engine error.

chad accepted this revision.Jan 21 2016, 5:40 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 21 2016, 5:40 PM

Closed by commit rPHUb4edc1af066d: Give PhutilRope and LinesOfALarge a couple new capabilities (authored by epriestley, committed by epriestley). · Explain WhyJan 21 2016, 5:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

filesystem/

linesofalarge/

LinesOfALarge.php

22 lines

utils/

PhutilRope.php

28 lines

Diff 36394

View Options

src/filesystem/linesofalarge/LinesOfALarge.php