Differential D15056

Allow profile menus to be collapsed and expanded
ClosedPublic
Actions

Authored by epriestley on Jan 19 2016, 8:43 PM.

Details

Reviewers

chad

Maniphest Tasks

T10054: Define product direction for Project/Profile UIs

Commits

Restricted Diffusion Commit
rP0a554c2ed535: Allow profile menus to be collapsed and expanded

Summary

Ref T10054. I think this gets everything except:

circles on icons;
I spent ~15 minutes poking at animations but wasn't able to get anything that looked reasonable whatsoever.

Test Plan

Collapsed menus.
Expanded menus.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36360.Jan 19 2016, 8:43 PM

epriestley retitled this revision from to Allow profile menus to be collapsed and expanded.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10054: Define product direction for Project/Profile UIs.

Herald edited edge metadata. · View Herald TranscriptJan 19 2016, 8:43 PM

chad added inline comments.Jan 19 2016, 8:50 PM

webroot/rsrc/css/phui/phui-profile-menu.css
81	<.<

Here's subpixel:

Here's antialiased:

Subpixel retina:

Antialiased retina:

Screen Shot 2016-01-19 at 12.59.13 PM.png (1×282 px, 42 KB)

At the smaller size, the type feels a little frail to me with "antialiased", but I'm happy to drop the subpixel stuff if you like the thinner type.

Actually, I kind of like "antialiased" better on retina, even at the small size.

On non-retina, I think the "frailness" I'm seeing comes from stuff like the vertical lines in "..rk..d" in "workboard", where they're trying to render with the line not aligned on the pixels and look sort of smushed and blurry. With "subpixel" that effect is less pronounced because all the type is heavier, maybe?

I'll just drop it for now and you can fiddle with it later if you want.