Differential D15054

When publishing project transactions, load ancestor members
ClosedPublic
Actions

Authored by epriestley on Jan 19 2016, 5:53 PM.

Tags

None

Referenced Files

	F15438600: D15054.id36358.diff
	Wed, Mar 26, 1:55 AM

	F15434525: D15054.id36355.diff
	Tue, Mar 25, 4:17 AM

	F15430959: D15054.id.diff
	Mon, Mar 24, 9:52 AM

	F15428567: D15054.diff
	Sun, Mar 23, 9:12 PM

	F15394444: D15054.id.diff
	Sat, Mar 15, 11:52 PM

	F15383179: D15054.id36358.diff
	Fri, Mar 14, 3:45 PM

	F15374673: D15054.id.diff
	Wed, Mar 12, 8:15 PM

	F15374672: D15054.diff
	Wed, Mar 12, 8:15 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10010: Implement Subprojects
T10107: (PhabricatorDataNotAttachedException) Attempting to access attached data on PhabricatorProject, but the data is not actually attached.

Commits

Restricted Diffusion Commit
rPc51752b4aa79: When publishing project transactions, load ancestor members

Summary

Ref T10010. Fixes T10107. When we publish a transaction about a project, we perform visibility checks for many different users. We need to know all of the ancestors' members to perform these checks.

Test Plan

Before patch: when updating a subproject, daemons fatal trying to publish things because they can not test visibility of parent projects.
After patch: daemons successfully publish subproject updates.
Also added a unit test.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36355.Jan 19 2016, 5:53 PM

epriestley retitled this revision from to When publishing project transactions, load ancestor members.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10107: (PhabricatorDataNotAttachedException) Attempting to access attached data on PhabricatorProject, but the data is not actually attached., T10010: Implement Subprojects.

chad accepted this revision.Jan 19 2016, 5:59 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 19 2016, 5:59 PM

Closed by commit rPc51752b4aa79: When publishing project transactions, load ancestor members (authored by epriestley, committed by epriestley). · Explain WhyJan 19 2016, 6:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

__tests__/

PhabricatorProjectCoreTestCase.php

69 lines

editor/

PhabricatorProjectTransactionEditor.php

2 lines

query/

PhabricatorProjectQuery.php

40 lines

Diff 36358

src/applications/project/tests/PhabricatorProjectCoreTestCase.php

Loading...

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...

src/applications/project/query/PhabricatorProjectQuery.php

Loading...