Page MenuHomePhabricator

Remove defunt project image choices
ClosedPublic

Authored by chad on Jan 19 2016, 2:40 AM.
Tags
None
Referenced Files
F13239841: D15051.diff
Wed, May 22, 7:10 AM
F13230665: D15051.diff
Mon, May 20, 11:14 PM
F13226847: D15051.id.diff
Sun, May 19, 11:41 PM
F13210316: D15051.diff
Fri, May 17, 4:42 AM
F13195847: D15051.diff
Sun, May 12, 10:40 PM
Unknown Object (File)
Thu, May 2, 11:01 PM
Unknown Object (File)
Thu, May 2, 2:47 PM
Unknown Object (File)
Thu, May 2, 2:47 PM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPf7646b40aace: Remove defunt project image choices
Summary

These are old project image choices, remove and only go with FontAwesome related images.

Test Plan

Project -> Edit Picture -> Save

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Remove defunt project image choices.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.

There's no real reason not to keep these around as extra options, unless you don't want to or worry that there will be way too many options once we fully slice FA?

I'd imagine possibly using this composer UI for Phame (and maybe even Users?) in the future, so having even more variety seems sort of nice. Although it could get overwhelming if you have 2000 options to pick from, but we could do grouping or something eventually.

(That said, I don't think we use the actual sprite or have any plans to do so, nor the 1x images, since we always compose PNGs from the sources.)

I roughly plan to land a handful of fa equivalent. I just didn't want to overload this diff. "All" fa is a bit overkill unless its a typeahead.

epriestley edited edge metadata.

Oh, I suppose most of these actually do have near-duplicates in FA and the rest I'm not terribly attached to (like "8ball").

This revision is now accepted and ready to land.Jan 19 2016, 3:31 PM

can I move these out of /sprite/ then?

Yeah, just fix the path in IconComposerBuiltinFile too.

chad edited edge metadata.
  • Remove sprite sheet

We were using the sprite sheet in the file composer, so I re-wrote that as fonts instead.

Ah, sure. We can swap that for composed builtins too if we do want to add non-FA images eventually.

Honestly haven't found setting project images to be very helpful.

This revision was automatically updated to reflect the committed changes.

I think it would be more useful if we were larger. This one's pretty good:

Screen Shot 2016-01-19 at 8.50.20 AM.png (166×456 px, 20 KB)

WMF has some really good ones, too:

Screen Shot 2016-01-19 at 8.52.21 AM.png (402×726 px, 87 KB)

Maybe we can go to 100px then (200px retina).