Page MenuHomePhabricator

Don't show the autocompleter until the user types at least one character
ClosedPublic

Authored by epriestley on Jan 16 2016, 9:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 13, 7:39 AM
Unknown Object (File)
Tue, Mar 5, 5:26 PM
Unknown Object (File)
Tue, Mar 5, 9:15 AM
Unknown Object (File)
Tue, Mar 5, 9:15 AM
Unknown Object (File)
Tue, Mar 5, 9:15 AM
Unknown Object (File)
Feb 17 2024, 7:35 PM
Unknown Object (File)
Feb 17 2024, 6:36 PM
Unknown Object (File)
Feb 11 2024, 7:48 PM
Subscribers
None

Details

Summary

Ref T10163. Activate on @d, not just @. Note that if you type @d and then press delete once so you're left with @, we stay active (and show the "type a username" hint).

Test Plan
  • Typed @, no completer.
  • Typed d, got completer.
  • Typed delete, still had completer, now showing hint prompt.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't show the autocompleter until the user types at least one character.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.

hows it feel?

This revision is now accepted and ready to land.Jan 16 2016, 9:49 PM

I'm not sure. I like it more, but I'm not really the target audience for this feature.

This revision was automatically updated to reflect the committed changes.