Page MenuHomePhabricator
Differential D15037

Don't show the autocompleter until the user types at least one character
ClosedPublic
Actions

Authored by epriestley on Jan 16 2016, 9:45 PM.
Tags
None
Referenced Files
F14314478: D15037.id.diff
Wed, Dec 18, 5:18 AM
F14309772: D15037.diff
Wed, Dec 18, 1:09 AM
F14309523: D15037.id36322.diff
Wed, Dec 18, 1:03 AM
F14309514: D15037.id36318.diff
Wed, Dec 18, 1:03 AM
F14309510: D15037.id.diff
Wed, Dec 18, 1:03 AM
F14309509: D15037.diff
Wed, Dec 18, 1:03 AM
Unknown Object (File)
Mon, Dec 16, 4:16 AM
Unknown Object (File)
Fri, Dec 13, 4:31 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10163: Remarkup Autocomplete Errata
Commits
Restricted Diffusion Commit
rP14ebf662f30a: Don't show the autocompleter until the user types at least one character
Summary

Ref T10163. Activate on @d, not just @. Note that if you type @d and then press delete once so you're left with @, we stay active (and show the "type a username" hint).

Test Plan
  • Typed @, no completer.
  • Typed d, got completer.
  • Typed delete, still had completer, now showing hint prompt.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36318.Jan 16 2016, 9:45 PM
epriestley retitled this revision from to Don't show the autocompleter until the user types at least one character.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10163: Remarkup Autocomplete Errata.
chad accepted this revision.Jan 16 2016, 9:49 PM
chad edited edge metadata.

hows it feel?

This revision is now accepted and ready to land.Jan 16 2016, 9:49 PM
epriestley added a comment.Jan 16 2016, 10:02 PM

I'm not sure. I like it more, but I'm not really the target audience for this feature.

Closed by commit rP14ebf662f30a: Don't show the autocompleter until the user types at least one character (authored by epriestley, committed by epriestley). · Explain WhyJan 16 2016, 10:38 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10163: Remarkup Autocomplete Errata.Jan 16 2016, 10:49 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
16 lines
webroot/
rsrc/
js/
phuix/
31 lines

Diff 36322

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXAutocomplete.js

Loading...
Phabricator · Built by Phacility