Paths

Table of Contentst

Differential D15000

If the Script-and-Regex linter captures no "line" text, treat the message as affecting the entire file
ClosedPublic
Actions

Authored by epriestley on Jan 12 2016, 1:24 AM.

Details

Reviewers

chad

Maniphest Tasks

T10124: Script-and-regex linter doesn't handle whole file lint correctly.

Commits

rARC05c12eb9d9cb: If the Script-and-Regex linter captures no "line" text, treat the message as…

Summary

Fixes T10124.

Test Plan

Added this "linter" to .arclint:

"thing": {
  "type": "script-and-regex",
  "script-and-regex.script": "echo every file is very bad #",
  "script-and-regex.regex": "/^(?P<message>.*)/"
}

...to produce this diff. Also made a variant of it which matches lines to make sure that still works.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36236.Jan 12 2016, 1:24 AM

epriestley retitled this revision from to If the Script-and-Regex linter captures no "line" text, treat the message as affecting the entire file.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10124: Script-and-regex linter doesn't handle whole file lint correctly..

epriestley mentioned this in T10124: Script-and-regex linter doesn't handle whole file lint correctly..Jan 12 2016, 1:26 AM

chad accepted this revision.Jan 12 2016, 1:28 AM

chad edited edge metadata.

chad added inline comments.

src/lint/linter/ArcanistScriptAndRegexLinter.php
1	I feel like there should be something spinning here.

This revision is now accepted and ready to land.Jan 12 2016, 1:28 AM

Remove example changes to .arclint now that we've all had a right jolly giggle.

Closed by commit rARC05c12eb9d9cb: If the Script-and-Regex linter captures no "line" text, treat the message as… (authored by epriestley, committed by epriestley). · Explain WhyJan 12 2016, 1:37 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistScriptAndRegexLinter.php

12 lines

Diff 36240

View Options

src/lint/linter/ArcanistScriptAndRegexLinter.php

If the Script-and-Regex linter captures no "line" text, treat the message as affecting the entire fileClosedPublicActions