Page MenuHomePhabricator

Enforce sensible, unique clone/checkout names for repositories
ClosedPublic

Authored by epriestley on Jan 10 2016, 7:18 PM.

Details

Summary

Fixes T7938.

  • Primarily, users can currently shoot themselves in the foot by putting ../../etc/passwd and other similar nonsense in these fields (this is not dangerous, but also does not work). Require sensible names.
  • Enforce uniqueness so these names can be used in URIs and as identifiers in the future.
  • (This doesn't start actually using them for anything fancy yet.)
Test Plan
  • Gave several repositories clone names: a valid name, two duplicate names, an invalid, name, some with no names.
  • Ran migrations.
  • Got clean conversion for valid names, appropriate errors for invalid/duplicate names.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Enforce sensible, unique clone/checkout names for repositories.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.

Nice tests!

This revision is now accepted and ready to land.Jan 11 2016, 1:08 AM
This revision was automatically updated to reflect the committed changes.