Modernize `bin/files migrate` and fix behavior on chunk engines
ClosedPublic
Actions

Authored by epriestley on Jan 9 2016, 5:49 PM.

Details

Reviewers

chad

Maniphest Tasks

T9828: Make migrating files less scary

Commits

Restricted Diffusion Commit
rP67ac356b0327: Modernize `bin/files migrate` and fix behavior on chunk engines

Summary

Ref T9828. Mostly just does a minor modernization pass, but also doesn't migrate chunked files since it's not meaningful (they don't have data, directly).

Test Plan

Ran bin/files migrate with various flags. Migrated S3 -> Blob and Blob -> S3.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36189.Jan 9 2016, 5:49 PM

epriestley retitled this revision from to Modernize `bin/files migrate` and fix behavior on chunk engines.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9828: Make migrating files less scary.

chad accepted this revision.Jan 9 2016, 6:49 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 9 2016, 6:49 PM

Closed by commit rP67ac356b0327: Modernize `bin/files migrate` and fix behavior on chunk engines (authored by epriestley, committed by epriestley). · Explain WhyJan 9 2016, 7:46 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T9828: Make migrating files less scary.Jan 10 2016, 4:13 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

management/

PhabricatorFilesManagementMigrateWorkflow.php

96 lines

Diff 36190

View Options

src/applications/files/management/PhabricatorFilesManagementMigrateWorkflow.php

Modernize `bin/files migrate` and fix behavior on chunk enginesClosedPublicActions